From 674712ac224b70c7338a5c3f15f950bc8cdd8159 Mon Sep 17 00:00:00 2001
From: Mike Mai <48327829+MaiDeveloper@users.noreply.github.com>
Date: Wed, 15 Jan 2025 11:05:16 -0500
Subject: [PATCH] fix(ebay-combobox): floating label type (#2370)

---
 .changeset/sharp-bees-grin.md             | 5 +++++
 src/components/ebay-combobox/component.ts | 4 ++--
 2 files changed, 7 insertions(+), 2 deletions(-)
 create mode 100644 .changeset/sharp-bees-grin.md

diff --git a/.changeset/sharp-bees-grin.md b/.changeset/sharp-bees-grin.md
new file mode 100644
index 000000000..e55b47f2e
--- /dev/null
+++ b/.changeset/sharp-bees-grin.md
@@ -0,0 +1,5 @@
+---
+"@ebay/ebayui-core": patch
+---
+
+TS fix for combobox
diff --git a/src/components/ebay-combobox/component.ts b/src/components/ebay-combobox/component.ts
index dbf4caf76..27776e721 100644
--- a/src/components/ebay-combobox/component.ts
+++ b/src/components/ebay-combobox/component.ts
@@ -4,7 +4,7 @@ import Expander from "makeup-expander";
 import { scroll } from "../../common/element-scroll";
 import * as eventUtils from "../../common/event-utils";
 import safeRegex from "../../common/build-safe-regex";
-import type { AttrClass } from "marko/tags-html";
+import type { AttrClass, AttrString } from "marko/tags-html";
 import type { WithNormalizedProps } from "../../global";
 
 export interface ComboboxOption {
@@ -26,7 +26,7 @@ interface ComboboxInput extends Omit<Marko.Input<"input">, `on${string}`> {
     fluid?: boolean;
     autocomplete?: "list" | "none";
     "list-selection"?: "manual" | "automatic";
-    "floating-label"?: boolean;
+    "floating-label"?: AttrString;
     "view-all-options"?: boolean;
     button?: Marko.Input<"button"> &
         Marko.AttrTag<{