Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TheiaBackendModelServerClientV2.edit() does not work with CompoundCommand #144

Open
kubomann opened this issue Jun 1, 2023 · 0 comments
Labels
bug Something isn't working modelserver EMF.cloud Model Server Theia

Comments

@kubomann
Copy link

kubomann commented Jun 1, 2023

TheiaModelServerClientV2.edit() worked if I set the SetCommand as an argument.
However, it didn't work if I included SetCommand in CompoundCommand and set CompoundCommand as an argument.

TheiaBackendModelServerClientV2.edit() is currently implemented as follows:

    edit(modeluri: URI, patchOrCommand: PatchOrCommand, format?: Format): Promise<ModelUpdateResult> {
        if (ModelServerCommand.is(patchOrCommand)) {
            return super.edit(modeluri, ensureCommandPrototype(patchOrCommand));
        }
        return super.edit(modeluri, patchOrCommand, format);
    }

The if clause should check for both command types (e.g. like if (ModelServerCommand.is(patchOrCommand) || CompoundCommand.is(patchOrCommand))).

( refs. eclipse-emfcloud/emfcloud#209 )

@kubomann kubomann added bug Something isn't working modelserver EMF.cloud Model Server Theia labels Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working modelserver EMF.cloud Model Server Theia
Projects
None yet
Development

No branches or pull requests

1 participant