Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JaCoCo code coverage report is not computed correctly #266

Open
ndoschek opened this issue Jan 11, 2023 · 2 comments · May be fixed by #278
Open

JaCoCo code coverage report is not computed correctly #266

ndoschek opened this issue Jan 11, 2023 · 2 comments · May be fixed by #278
Labels
bug Something isn't working modelserver EMF.cloud Model Server testing

Comments

@ndoschek
Copy link
Contributor

We are using JaCoCo in separate package to compute code coverage, with current master the values are not computed correctly anymore, we get 0% coverage for all packages.

  • Check why this does not work correctly anymore.

Also, is this report still relevant for our use case? As we do not publish the coverage anywhere, we could remove the separate package and describe in the README how to compute the coverage with EclEmma in Eclipse (also based on JaCoCo).
@ndoschek ndoschek added bug Something isn't working testing modelserver EMF.cloud Model Server labels Jan 11, 2023
@ndoschek ndoschek changed the title JaCoco code coverage report is not computed correctly JaCoCo code coverage report is not computed correctly Jan 17, 2023
@eneufeld
Copy link
Contributor

I would love to keep it. We should actually improve here even more and check that a PR does not decrease the coverage (significantly).

@vhemery vhemery linked a pull request Jan 9, 2025 that will close this issue
Open
@vhemery
Copy link
Contributor

vhemery commented Jan 9, 2025

The PR solves the coverage report.
I did not implement the PR check because I'm not sure what the best option for the project would be.
There are several options out there:

Plus that would imply an extra build or refactoring the current build github action where we arleady have 4 different builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working modelserver EMF.cloud Model Server testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add code coverage for jacoco. eclipse-emfcloud/emfcloud-modelserver
3 participants
@eneufeld @vhemery @ndoschek