ASTParser.createBindings does not use the unitResolver field #3428
Comments
robstryker
pushed a commit
to robstryker/eclipse.jdt.core
that referenced
this issue
Dec 9, 2024
… the correct unit resolver Signed-off-by: Rob Stryker <[email protected]>
|
@robstryker I see a commit, but no pull request. Can you create one if not done already or point me to the PR? |
robstryker
pushed a commit
to robstryker/eclipse.jdt.core
that referenced
this issue
Jan 8, 2025
… the correct unit resolver Signed-off-by: Rob Stryker <[email protected]>
|
The PR is over here: #3429 |
robstryker
pushed a commit
to robstryker/eclipse.jdt.core
that referenced
this issue
Jan 9, 2025
… the correct unit resolver Signed-off-by: Rob Stryker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ASTParser.createBindings does not direct such requests to the current unitResolver, but rather uses the ECJ implementation with no opportunity to override it.
I have moved the method into ASTParser and added a parameter for the proper unit resolver to be used. Since this is a public package, I have left the old method where it was (in CompilationUnitResolver) and forwarded the request to the newer method.
The text was updated successfully, but these errors were encountered: