Replace some colossal strings in the compiler tests #3581
+163
−13,148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datho7561
force-pushed
the
remove-colossal-strings
branch
from
583ba8a to
9fc5ce0
Compare
datho7561
force-pushed
the
remove-colossal-strings
branch
2 times, most recently
from
486364e to
543d3ea
Compare
|
One of the test cases had imbalanced brackets; I think I've fixed it now but I want to see the test results first but I'll wait for CI before marking this as ready for review. update: okay it seems to be passing now |
There are some very large string literals in the compiler tests. These string literals make the code hard to read, since you have to scroll down thousands of lines to see the rest of the test case. Since these strings are very repetitive, they can be easily generated with a `StringBuilder` and for loops. After this change, we will still be testing that ECJ can compile colossal strings, since there is a test case for that. Signed-off-by: David Thompson <[email protected]>
datho7561
force-pushed
the
remove-colossal-strings
branch
from
543d3ea to
938ea1e
Compare
rgrunber
reviewed
Jan 20, 2025
There was a problem hiding this comment.
Overall looks good. There's nothing that explicitly states the file being maintained must also be "very large", so as long as the testcase is still testing a large source file, it should be fine.
Just wondering why you left out some cases of test00NM in XLargeTest. Not that halving the size of the source file isn't great (but ~12k is still a large file).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some very large string literals in the compiler tests. These string literals make the code hard to read, since you have to scroll down thousands of lines to see the rest of the test case. Since these strings are very repetitive, they can be easily generated with a
StringBuilderand for loops.After this change, we will still be testing that ECJ can compile colossal strings, since there is a test case for that.
What it does
Replace some colossal string literals in the compiler tests with strings built using
StringBuilderand for loops.How to test
Run the compiler test suite. The tests should compile, run, and pass.
Author checklist