Primitive arrays and Lambdas type on variables view #595
+19
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jukzi
reviewed
Jan 15, 2025
| @@ -1917,11 +1924,20 @@ public String removeQualifierFromGenericName(String qualifiedName) { | |||
| /** | |||
| * Return the simple name from a qualified name (non-generic) | |||
| */ | |||
| @SuppressWarnings("nls") | |||
There was a problem hiding this comment.
Will this work for ShowQualifiedNames? While it is unlikely, technical any class could be named "$Lambda" so it would be better if somehow this could be solved by not using text replacement only.
There was a problem hiding this comment.
with ShowQualifiedNames enabled it will show its original value eg. $$Lambda.0x000000f001007608 . Unfortunately vm only gives this as IValue for every lambdas compared to other objects. so only went with text replacement.
jukzi
approved these changes
Jan 15, 2025
SougandhS
force-pushed
the
primitiveArrayDebugView
branch
from
952e6bc to
344ebaf
Compare
eclipse-jdt#592 This commit provides fix for not showing primitive arrays and lambdas correctly in debug view. Fixes : eclipse-jdt#592
SougandhS
force-pushed
the
primitiveArrayDebugView
branch
from
344ebaf to
69062bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#592
This commit provides fix for not showing primitive arrays and lambdas correctly in variables view.
Fixes : #592
Before fix -
After -
What it does
How to test
Author checklist