Use the new ISharedImages.get() to not require a running platform #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laeubi
force-pushed
the
check_if_platform_running
branch
from
4e77567 to
4e2cd4d
Compare
laeubi
force-pushed
the
check_if_platform_running
branch
from
4e2cd4d to
5a4d417
Compare
laeubi
changed the title
|
I triggered a new Ibuild so the changes can be seen here: |
Currently some actions require a running platform, but with the new ISharedImages.get() method this is no longer required making the classes less coupled.
laeubi
force-pushed
the
check_if_platform_running
branch
from
5a4d417 to
b62b694
Compare
|
The two "new warnings" seem not related to my change @akurtakov can you review/merge? |
|
The 2 new deprecations seems to come from eclipse-jdt/eclipse.jdt.core#3572 so this is expected. |
akurtakov
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently some actions require a running platform, but with the new
ISharedImages.get() method this is no longer required making the classes
less coupled.
I'm currently working on an automated way to fix certain warnings in the platform code. One of that kind is
but encountered a problem because currently apply this quickfix outside of a "real" IDE yields:
because the quickfix try to fetch a shared image.
This now adds a guard around the call for a shared image to allow to proceed in this case with a (possibly not optimal) image instead of completely fail.