Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only load the target platform on user request and not automatically #917

Open
vogella opened this issue Nov 13, 2023 · 3 comments
Open

Only load the target platform on user request and not automatically #917

vogella opened this issue Nov 13, 2023 · 3 comments

Comments

@vogella
Copy link
Contributor

vogella commented Nov 13, 2023

Extraced from @laeubi comment https://bugs.eclipse.org/bugs/show_bug.cgi?id=576844#c3

I think the target should only ever be updated if I actively press "Set as active Target".

Also from @HannesWell coment https://bugs.eclipse.org/bugs/show_bug.cgi?id=576844#c5

The Target-Platform should only be refreshed/reloaded/updated if asked to do so for the reasons you have mentioned.
@laeubi
Copy link
Contributor

laeubi commented Nov 13, 2023

I think it is a bit unclear here what means "Only load the target platform on user request", what should happen is that the target is loaded + resolved but it should not replace the current target platform state unless user press Set as active Target or Reload Target.

@HannesWell
Copy link
Member

what should happen is that the target is loaded + resolved but it should not replace the current target platform state unless user press Set as active Target or Reload Target.

Absolutely.

Recently I already started to look into the TP resolving/reloading process in more detail with the goal to make it more robust.
Changing this was one goal of that.
I'm currently contemplating to try out Christophs suggestion from a short chat about this topic at EclipseCon, that actually the resolution could happen without a P2-profile.
Of course the resolution should happen purely on P2 metadata and should not download any artifact (I actually had the impression that this would happen on set/reload, but I'll verify this).

@laeubi
Copy link
Contributor

laeubi commented Dec 16, 2023

@vogella can you check latest release? There should be a noticeable speed improvement already now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants