Reduce "Discouraged access" warnings

[jukzi]

No description provided.

[github-actions]

Test Results

     270 files       270 suites   42m 31s ⏱️
  3 329 tests   3 299 ✔️ 30 💤 0 ❌
10 284 runs  10 194 ✔️ 90 💤 0 ❌

Results for commit 83e5af9.

♻️ This comment has been updated with latest results.

[jukzi]

why is marked as fail while there are no fails?

[laeubi]

Because you added one new compiler warning (and yes the mention of test failure is WRONG please report it to the author of the Jenkins plugin):

Also you clicked already on https://ci.eclipse.org/pde/job/eclipse.pde/job/PR-989/1/ you see a small orange warning here:

Compare for example with something that has found issues but no new ones:

[jukzi]

Because you added one new compiler warning (and yes the mention of test failure is WRONG please report it to the author of the Jenkins plugin):

Thanks for the explanation. can it be configured, that a reduction of warnings (7 reduced here, 1 was just moved) does not count as error?

(and yes the mention of test failure is WRONG please report it to the author of the Jenkins plugin):

who's that author? or the used plugin, please

[laeubi]

The configuration options are here but I think one can't exchange one warning for another.

The plugin that publishes Warnings from Jenkins > Gitbub is this here, the build itself seems to be contributed by this.

Of course if one think it should do that one can still merge.

[akurtakov]

It would be a bit noisy initially as it will require extra fixes in order to not produce new warnings but over time such cases should be rarer and rarer aka I'm more and more convinced this is good path forward.