Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntax coloring in quick search #103

Closed
jabby opened this issue Oct 18, 2022 · 2 comments
Closed

Add syntax coloring in quick search #103

jabby opened this issue Oct 18, 2022 · 2 comments

Comments

@jabby
Copy link
Contributor

jabby commented Oct 18, 2022

I'm not sure this is the right project.

What do you think about adding syntax coloring to quick search dialog ? When I select one result to see if it's the code I'm lookin for, it will help me to figure out.

First I though that tm4e can provide the syntax coloring then I realised this will create a circular dependencies between platform and tm4e. I found issue eclipse-platform/eclipse.platform.ui#877 about the same kind of problem.

@mickaelistria
Copy link
Contributor

The same comment would generally apply to any place where we show an extract of some file (typically to the Search results view as well).
AS you mentioned, it's relatively tricky as syntax highlighted is delegating to external editors & plugins and we may not want to load them all.

@jukzi
Copy link
Contributor

jukzi commented May 17, 2023

I'm closing this issues as it probably can't be implemented. I'm sure the feature itself would be welcome. @jabby Just reopen if you could contribute a feasible implementation, starting with giving a Screenshot for a discussion how it would look like.

@jukzi jukzi closed this as not planned Won't fix, can't repro, duplicate, stale May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants