Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FedX: optimizer does not insert (external) bindings prior to source selection #5227

Open
aschwarte10 opened this issue Jan 13, 2025 · 0 comments · May be fixed by #5228
Open

FedX: optimizer does not insert (external) bindings prior to source selection #5227

aschwarte10 opened this issue Jan 13, 2025 · 0 comments · May be fixed by #5228
Assignees
@aschwarte10
Labels
🐞 bug issue is a bug 📦 fedx fedx: optimized federated query support
Milestone
5.1.1

Comments

@aschwarte10
Copy link
Contributor

Current Behavior

The FedX Optimizer is missing to inject bindings (e.g. from Query#setBinding()) into the statement patterns.

This can cause poor behavior in caching.

Expected Behavior

FedX injects bindings properly

Steps To Reproduce

TupleQuery tq = conn.prepareTupleQuery("SELECT * WHERE { ?subject a ?type }");
tq.setBinding("subject", subjectIri);

Inspect the query plan during optimization

Version

5.1.0

Are you interested in contributing a solution yourself?

Yes

Anything else?

No response
@aschwarte10 aschwarte10 added the 🐞 bug issue is a bug label Jan 13, 2025
@aschwarte10 aschwarte10 added this to the 5.1.1 milestone Jan 13, 2025
@aschwarte10 aschwarte10 added the 📦 fedx fedx: optimized federated query support label Jan 13, 2025
@aschwarte10 aschwarte10 self-assigned this Jan 13, 2025
aschwarte10 added a commit that referenced this issue Jan 14, 2025
@aschwarte10
GH-5227: fix binding assigner optimizer in FedX
fa65202 
The federation optimizer was missing to execute the binding assigner
(which injects external bindings into the statement pattern). The
consequence was potentially incorrect results (due to source source
selection with partial knowledge) as well as sub-optimal source
selection

Issue is covered with a unit test, which is failing in two places prior
to this change.
@aschwarte10 aschwarte10 linked a pull request Jan 14, 2025 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aschwarte10 aschwarte10

Labels
🐞 bug issue is a bug 📦 fedx fedx: optimized federated query support
Projects
None yet
Milestone
5.1.1
Development

Successfully merging a pull request may close this issue.

GH-5227: fix binding assigner optimizer in FedX eclipse-rdf4j/rdf4j
1 participant
@aschwarte10