Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink client-only layout scenario #55

Open
spoenemann opened this issue Sep 26, 2019 · 0 comments
Open

Rethink client-only layout scenario #55

spoenemann opened this issue Sep 26, 2019 · 0 comments

Comments

@spoenemann
Copy link
Contributor

When the client requests a model with client-side layout, but no server-side layout, the server responds with a RequestBoundsAction. The client never replies to that second request, but generates a SetBoundsAction locally:

https://github.com/eclipse/sprotty/blob/d039fe732581f7626da34852160b038f06f21b38/src/model-source/diagram-server.ts#L184-L198

This is a bit strange. The server should send a SetModelAction instead, and the client should take care of the RequestBounds / ComputedBounds cycle locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant