Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Should async_std be replaced with tokio ? #265

Open
Hennzau opened this issue Jan 7, 2025 · 2 comments
Open

[Enhancement] Should async_std be replaced with tokio ? #265

Hennzau opened this issue Jan 7, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@Hennzau
Copy link
Contributor

Hennzau commented Jan 7, 2025

Current behaviour and limitations

Since #261, Zenoh-Flow has been based on Zenoh 1.x. A major change in this version of Zenoh is that task management has shifted from async_std to tokio (eclipse-zenoh/zenoh#1264).

Should Zenoh-Flow migrate entirely to tokio?

Proposed solution?

No response

@Hennzau Hennzau added the enhancement New feature or request label Jan 7, 2025
@J-Loudet
Copy link
Contributor

Hi @Hennzau!

In short, yes we should probably switch to Tokio.

The longer answer is that we had internal plans to use a patched version of async-std to provide additional functionalities. For instance, assigning a priority to a task. Unfortunately, due to external factors, these plans are now postponed and to have a more consistent software stack between the Zenoh and Zenoh-Flow projects, Tokio is the better default.

@Hennzau
Copy link
Contributor Author

Hennzau commented Jan 13, 2025

Alright! Yes, I remember M. Angelo C mentioning this version of async_std.

I’ll update the code to use tokio!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants