Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EC only texture misalignment. #767

Open
LoboEire opened this issue Dec 23, 2024 · 2 comments
Open

EC only texture misalignment. #767

LoboEire opened this issue Dec 23, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@LoboEire
Copy link
Collaborator

In EC, map01 of this wad has a misaligned texture.
https://www.doomworld.com/forum/topic/128999-squenched-avacausage-bite-1a-boom-map-1-to-13/
It should look like this:
Screenshot_Doom_20241214_104317

But in EC it looks like this:
shot39

@LoboEire LoboEire added the bug Something isn't working label Dec 23, 2024
@dashodanger dashodanger added this to the EDGE-Classic 1.5 Release milestone Jan 10, 2025
@pbdot
Copy link
Collaborator

pbdot commented Jan 11, 2025

I've been looking into this and it isn't map related. The texture in question is 72 high, and the offset being applied is 72, normally that would just wrap back to 0. However, non-power-of-two textures are promoted, so in this case becomes 128 high... and then have their margins filled. If you don't fill the margin you can see below where the offset is landing things... ie. in the non-tiling "filled" space

I looked into how DSDA doom handles this and it checks whether a surface needs to tile based on the height, though that doesn't support the scaling and stuff that EC does. It is possible to fix this for this specific case, by checking the texture height against the offset, though would really like a more holistic fix.

Basically, you can't get a 72 px high texture to ever tile in a power of two, and the offsets are being applied in the 72 pixel space, when the actual texture is 128 high.

shot13

@LoboEire
Copy link
Collaborator Author

Thanks for the explanation.
Seems like a potential fix would need careful consideration or it could cause more issues with other things than it's worth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants