Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IWAD-specific definitions from edge_defs #800

Open
dashodanger opened this issue Jan 7, 2025 · 4 comments
Open

Remove IWAD-specific definitions from edge_defs #800

dashodanger opened this issue Jan 7, 2025 · 4 comments
Assignees
Labels
implementation Change or improvement to how an existing feature is implemented

Comments

@dashodanger
Copy link
Member

This will prevent potential conflicts, i.e. trying to load a Doom 2 map from a PWAD when Doom 1 is the IWAD, etc. edge_defs should ideally be a very minimal core that a standalone game/pack would require to function

@dashodanger dashodanger added the implementation Change or improvement to how an existing feature is implemented label Jan 7, 2025
@LoboEire
Copy link
Collaborator

LoboEire commented Jan 7, 2025

Actually this is a feature, not a bug.
In fact we went out of our way to make it happen IIRC, to allow loading Doom1, Doom2 and Sigil so you could choose from all 6 episodes in one boot.

@dashodanger
Copy link
Member Author

dashodanger commented Jan 7, 2025

Maybe as a good middle of the road solution, keep the defs aggregated but move copies of them to the Doom/Doom 2/Final Doom edge_base folders respectively so that we can still clear them out for the non-Doom games we support (and standalone titles)

@LoboEire
Copy link
Collaborator

LoboEire commented Jan 8, 2025

Standalone games should be using #CLEARALL at the start of all their defs if it is capable of being truely standalone.

@dashodanger
Copy link
Member Author

True, but DDFATK, DDFCOLM, DDFFONT, DDFIMAGE, DDFMOVIE, DDFSFX, DDFSTYLE, and DDFTHING are programmed to ignore the CLEARALL directive. Additionally, there are Doom-specific graphics/sounds/etc in edge_defs that wouldn't be needed for non-Doom games

@dashodanger dashodanger self-assigned this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
implementation Change or improvement to how an existing feature is implemented
Projects
None yet
Development

No branches or pull requests

2 participants