-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offset parameter? #11
Comments
Hmmm….
one of the reasons why those queries are so quick is because it actually doesn't look at the month at all :)
It just uses the `months` input as an int to grab from the array (e.g. when you pass `months` = 6 internally we say "give me data from indices 0,1,2,3,4,5").
Is there an issue with pull multiple months and then trimming client side (other than the obvious waste of bandwidth :) )
So it's certainly not *impossible* but what's the use case that we can't satisfy today ? (also bulk pulling data is materially faster than polling … e.g. getting 6 months of data at once is ~ the same time as getting 1 month)
Sent via Superhuman ( https://sprh.mn/[email protected] )
…On Thu, May 28, 2020 at 3:05 PM, samunderwood < ***@***.*** > wrote:
One more question if that’s okay. Is it possible to add something to
offset what month of data you want to pull?
For example, you can use months=2 to pull the past two months. But if I
want to compare to 6 months ago I have to pull 6 months of data rather
than just being able to specify I want 1 months worth of data from 6
months ago.
Maybe something like an ?offset=6 parameter or something would be handy?
Then I could do something like:
https:/ / api. crux. run/ v1/ summary/ overview/ ?domain=www. google. com&months=1
( https://api.crux.run/v1/summary/overview/?domain=www.google.com&months=1
)
For last month and then:
https:/ / api. crux. run/ v1/ summary/ overview/ ?domain=www. google. com&months=1&offset=6
(
https://api.crux.run/v1/summary/overview/?domain=www.google.com&months=1&offset=6
)
For 6 months ago.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub (
#11 ) , or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AE6P44QZ65EPKD76OCDSDFDRT3NZFANCNFSM4NNPMDOA
).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
One more question if that’s okay. Is it possible to add something to offset what month of data you want to pull?
For example, you can use months=2 to pull the past two months. But if I want to compare to 6 months ago I have to pull 6 months of data rather than just being able to specify I want 1 months worth of data from 6 months ago.
Maybe something like an ?offset=6 parameter or something would be handy?
Then I could do something like:
https://api.crux.run/v1/summary/overview/?domain=www.google.com&months=1
For last month and then:
https://api.crux.run/v1/summary/overview/?domain=www.google.com&months=1&offset=6
For 6 months ago.
The text was updated successfully, but these errors were encountered: