Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libbeat: use klauspost/compress for asset encoding and decoding #42207

Open
mauri870 opened this issue Jan 3, 2025 · 1 comment
Open

libbeat: use klauspost/compress for asset encoding and decoding #42207

mauri870 opened this issue Jan 3, 2025 · 1 comment
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Comments

@mauri870
Copy link
Member

mauri870 commented Jan 3, 2025

Recently I did a small optimization in the asset decoding that reduces the memory used during beats initialization by 20% at #42180. Looking at the code I think we can improve the cpu time as well(5-10%) by simply switching from compress/zlib to klauspost/compress/zlib.

This will likely cause changes in all the autogenerated fields.go files in the repo after running a make update. I don't fully understand how the asset encoding works but I assume that if we change both encoder and decoder so that they are compatible than it shouldn't cause any problems.

@mauri870 mauri870 added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Jan 3, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

No branches or pull requests

2 participants