Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation Detail: Logging should use logp everywhere #42247

Open
jrmolin opened this issue Jan 7, 2025 · 3 comments
Open

Implementation Detail: Logging should use logp everywhere #42247

jrmolin opened this issue Jan 7, 2025 · 3 comments
Assignees
Labels
Input:Netflow Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution

Comments

@jrmolin
Copy link

jrmolin commented Jan 7, 2025

Logging in Beats has standardized on github.com/elastic/elastic-agent-libs/logp for many important configuration and conformity reasons. Some of the Netflow Input code uses log.Logger directly, with a custom wrapper to let logp.Logger be used as a log.Logger.

This is confusing for developers who need to work with the Netflow code.

The only logging library that should be used in beats code is github.com/elastic/elastic-agent-libs/logp.

The custom wrapper in github.com/elastic/beats/input/netflow/input.go should be removed, and all associated calls changed to using the logp utilities.

This initial code is quite old, so it might have simply been overlooked by developers migrating to logp.

@jrmolin jrmolin self-assigned this Jan 7, 2025
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 7, 2025
@jrmolin jrmolin added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution labels Jan 8, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 8, 2025
@jrmolin
Copy link
Author

jrmolin commented Jan 8, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Input:Netflow Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution
Projects
None yet
Development

No branches or pull requests

2 participants