Implementation Detail: Logging should use logp everywhere #42247
Labels
Input:Netflow
Team:Elastic-Agent-Control-Plane
Label for the Agent Control Plane team
Team:Security-Deployment and Devices
Deployment and Devices Team in Security Solution
Logging in Beats has standardized on github.com/elastic/elastic-agent-libs/logp for many important configuration and conformity reasons. Some of the Netflow Input code uses
log.Logger
directly, with a custom wrapper to letlogp.Logger
be used as alog.Logger
.This is confusing for developers who need to work with the Netflow code.
The only logging library that should be used in beats code is github.com/elastic/elastic-agent-libs/logp.
The custom wrapper in github.com/elastic/beats/input/netflow/input.go should be removed, and all associated calls changed to using the
logp
utilities.This initial code is quite old, so it might have simply been overlooked by developers migrating to
logp
.The text was updated successfully, but these errors were encountered: