Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing to protoc-gen-validate, bumping to protobuf 0.11.0 #3

Open
fabriziosestito opened this issue Sep 12, 2022 · 1 comment

Comments

@fabriziosestito
Copy link

fabriziosestito commented Sep 12, 2022

I was able to update protoc-gen-validate to use protobuf 0.11.0 and vex 0.9.0 here: https://github.com/fabriziosestito/protoc-gen-validate/pull/2/commits

I used this fork https://github.com/aktsk/protoc-gen-validate as a starting point since the fork author has already done some work on bug fixing and dependency bumping.
Unfortunately, I am unable to contact the fork author since the fork does not allow issues.

Is the project still accepting PRs? If yes how should I proceed to incorporate changes from the fork repo and mine?

sekiyama58 pushed a commit to aktsk/protoc-gen-validate that referenced this issue Jun 4, 2024
* Handle oneof validation rules

* Add UUID string validation to extension

* Add message with UUID validation rule to example.proto

* Add uuid rule tests

* Add vex rule translation
sekiyama58 pushed a commit to aktsk/protoc-gen-validate that referenced this issue Jun 4, 2024
@sekiyama58
Copy link

@fabriziosestito I have merged your work into aktsk/protoc-gen-validate, in addition to protobuf 0.12.0 support. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants