-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2294 Accessibility violations fix - RadioButtons #2306
Open
srikant-ch5
wants to merge
11
commits into
elyra-ai:main
Choose a base branch
from
srikant-ch5:Accessibility-Violations-Fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
#2294 Accessibility violations fix - RadioButtons #2306
srikant-ch5
wants to merge
11
commits into
elyra-ai:main
from
srikant-ch5:Accessibility-Violations-Fix
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: srikant <[email protected]>
Signed-off-by: srikant <[email protected]>
Signed-off-by: srikant <[email protected]>
Signed-off-by: srikant <[email protected]>
…ing role and aria-label Signed-off-by: srikant <[email protected]>
Signed-off-by: srikant <[email protected]>
Signed-off-by: srikant <[email protected]>
Signed-off-by: srikant <[email protected]>
@@ -234,6 +234,8 @@ class RadiosetControl extends React.Component { | |||
orientation={this.props.control.orientation} | |||
helperText={this.props.control.helperText} | |||
readOnly={this.props.readOnly} | |||
// Provide unique aria-label for each radio button group | |||
aria-label={`Radio Button Group (${ControlUtils.getDataId(this.props.control, this.props.propertyId)})`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be translated?
srikant-ch5
changed the title
Accessibility violations fix - RadioButtons
#2294 Accessibility violations fix - RadioButtons
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2294
Developer's Certificate of Origin 1.1