Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting tags #86

Open
RobbieTheWagner opened this issue Dec 6, 2024 · 4 comments
Open

Setting tags #86

RobbieTheWagner opened this issue Dec 6, 2024 · 4 comments

Comments

@RobbieTheWagner
Copy link

Is there any way to set what the tag name should be of the release? For a package with one addon, like ember-math-helpers, I would like to make the tag just be v4.2.0 not v4.2.0-ember-math-helpers, that way I can have more normal version numbers to use for ember-cli-addon-docs.

@mansona
Copy link
Member

mansona commented Dec 6, 2024

So I think the simplest change here is that we should just use the non-suffixed version when there is only one package being released 🤔 That shouldn't be that big an issue. I also want to make it set the Github release name to be something less odd

@RobbieTheWagner
Copy link
Author

@mansona that sounds reasonable to me! How big of a lift is that? I'm working on getting everything automated for all my addons, and this is a blocker for me doing that, so I just want to set my expectations accordingly.

@mansona
Copy link
Member

mansona commented Dec 6, 2024

I mean this is the exact line that needs to change: https://github.com/embroider-build/release-plan/blob/main/src/publish.ts#L70 😂

The challenge is testing it 🤔 I'd be happy if we just did a unit test in the existing publish.test.ts, but I'm pretty adamant that we need at least a basic test before all changes since there are a lot of people depending on this.

Do you want to give it a go? 😂

@RobbieTheWagner
Copy link
Author

@mansona my brain is pretty fried currently, but I totally sympathize with not having time to do it all yourself. Perhaps we could stream and pair on it or something? I'm down to help, I just don't want to spin my wheels forever getting up to speed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants