Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deliver us from CKEditor #80

Open
sveetch opened this issue Oct 4, 2024 · 1 comment
Open

Deliver us from CKEditor #80

sveetch opened this issue Oct 4, 2024 · 1 comment
Labels
Enhancement Feature enhancement Help wanted Extra attention is needed Question Further information is requested

Comments

@sveetch
Copy link
Member

sveetch commented Oct 4, 2024

Is your feature request related to a problem? Please describe.
Since around 2023 CKEditor has changed its license that avoid django-ckeditor to include the new version.

The problem is that the CKEditor version shipped in django-ckeditor is known for some security issues and so it can be fixed since this version support has ended since a long time (maybe 2022 ?).

Hopefully the last django-ckeditor versions hide the warning from the editor but there is still a warning in console and finally the security breach is still there (even it is known to be uncommon to exploit).

Describe the solution you'd like
Lotus should not be tied anymore to django-ckeditor. It should allow to setup another editor. Maybe we would need to include ourself one or two additional editor setup just to ensure our interface is sufficient enough to work with many other editors.

The system should be simple as just defining a python path to a widget to use instead of the django-ckeditor one. Developers would have to manage their editor app settings themselves.

Describe alternatives you've considered
Just add hardcoded interface for other editor but this would be limited and would add more maintenance work.

Additional context
CKEditor is just used as a widget in forms, we should not have many things to do to make it more flexible.

@sveetch sveetch added Enhancement Feature enhancement Help wanted Extra attention is needed Question Further information is requested labels Oct 4, 2024
@sveetch sveetch added this to v0.9.1 Oct 14, 2024
@github-project-automation github-project-automation bot moved this to To do in v0.9.1 Oct 14, 2024
@sveetch
Copy link
Member Author

sveetch commented Oct 15, 2024

A non curated list of some editors:

This should be a proper list to start to see how we can implement a modular editor.

There should be an helper to find and init an editor in admin (only used in Article and Category models for now), maybe anotther one to sanytize and finally a final one to render content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Feature enhancement Help wanted Extra attention is needed Question Further information is requested
Projects
Status: To do
Development

No branches or pull requests

1 participant