From 9fdec038a70b53ac1950cca12fe2e59be5ddad84 Mon Sep 17 00:00:00 2001
From: Erik Berg <erik.berg@no.abb.com>
Date: Wed, 6 Nov 2024 15:01:19 +0100
Subject: [PATCH 1/4] change terminal Y type to NorsokSignalClass/Out

---
 NorsokSCDLibrary.aml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/NorsokSCDLibrary.aml b/NorsokSCDLibrary.aml
index e5c118b..714f8de 100644
--- a/NorsokSCDLibrary.aml
+++ b/NorsokSCDLibrary.aml
@@ -1,4 +1,4 @@
-<CAEXFile xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://www.dke.de/CAEX" SchemaVersion="3.0" FileName="NorsokSCDLibrary.aml" xsi:schemaLocation="http://www.dke.de/CAEX CAEX_ClassModel_V.3.0.xsd">
+<CAEXFile xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://www.dke.de/CAEX" SchemaVersion="3.0" FileName="NorsokSCDLibrary.aml" xsi:schemaLocation="http://www.dke.de/CAEX CAEX_ClassModel_V.3.0.xsd">
   <!-- reference to Whitepaper Part1 -->
   <AdditionalInformation DocumentVersions="Recommendations">
     <Document DocumentIdentifier="IEC63131AmlLibrary" Version="0.0.12" />
@@ -15695,7 +15695,7 @@
           <DefaultValue />
           <Value />
         </Attribute>
-        <ExternalInterface Name="Y" RefBaseClassPath="InterfaceClassLibrary/NorsokSignalClass/Out/AnalogueOut" ID="6b2117e3-8475-7e4b-9309-fed0ce98bac7">
+        <ExternalInterface Name="Y" RefBaseClassPath="InterfaceClassLibrary/NorsokSignalClass/Out" ID="6b2117e3-8475-7e4b-9309-fed0ce98bac7">
           <Description>Normal function output</Description>
           <Attribute Name="Direction" AttributeDataType="xs:string">
             <Description />

From 984821f2706ac6c32632acc23ef14b64d0d1fb27 Mon Sep 17 00:00:00 2001
From: Erik Berg <erik.berg@no.abb.com>
Date: Wed, 6 Nov 2024 15:05:25 +0100
Subject: [PATCH 2/4] remove SignalClass restriction

---
 NorsokSCDLibrary.aml | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/NorsokSCDLibrary.aml b/NorsokSCDLibrary.aml
index 714f8de..f1fe698 100644
--- a/NorsokSCDLibrary.aml
+++ b/NorsokSCDLibrary.aml
@@ -1,4 +1,4 @@
-<CAEXFile xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://www.dke.de/CAEX" SchemaVersion="3.0" FileName="NorsokSCDLibrary.aml" xsi:schemaLocation="http://www.dke.de/CAEX CAEX_ClassModel_V.3.0.xsd">
+<CAEXFile xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://www.dke.de/CAEX" SchemaVersion="3.0" FileName="NorsokSCDLibrary.aml" xsi:schemaLocation="http://www.dke.de/CAEX CAEX_ClassModel_V.3.0.xsd">
   <!-- reference to Whitepaper Part1 -->
   <AdditionalInformation DocumentVersions="Recommendations">
     <Document DocumentIdentifier="IEC63131AmlLibrary" Version="0.0.12" />
@@ -15711,11 +15711,7 @@
             <Description />
             <DefaultValue />
             <Value>Analogue</Value>
-            <Constraint Name="LegalValues">
-              <NominalScaledType>
-                <RequiredValue>Analogue</RequiredValue>
-              </NominalScaledType>
-            </Constraint>
+            <Constraint />
           </Attribute>
           <Attribute Name="CommunicationType" AttributeDataType="xs:string">
             <Description>Type of signal communcication</Description>

From c6759c2240cc441a90c4e89d171668837eeda4d8 Mon Sep 17 00:00:00 2001
From: Erik Berg <erik.berg@no.abb.com>
Date: Wed, 6 Nov 2024 15:51:53 +0100
Subject: [PATCH 3/4] restore Constraint, add Binary

---
 NorsokSCDLibrary.aml | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/NorsokSCDLibrary.aml b/NorsokSCDLibrary.aml
index f1fe698..5d45fd1 100644
--- a/NorsokSCDLibrary.aml
+++ b/NorsokSCDLibrary.aml
@@ -15711,7 +15711,12 @@
             <Description />
             <DefaultValue />
             <Value>Analogue</Value>
-            <Constraint />
+            <Constraint Name="LegalValues">
+              <NominalScaledType>
+                <RequiredValue>Analogue</RequiredValue>
+                <RequiredValue>Binary</RequiredValue>
+              </NominalScaledType>
+            </Constraint>
           </Attribute>
           <Attribute Name="CommunicationType" AttributeDataType="xs:string">
             <Description>Type of signal communcication</Description>

From ad7e628c52645391b04daf75ecff2a42da96e8e9 Mon Sep 17 00:00:00 2001
From: Erik Berg <erik.berg@no.abb.com>
Date: Wed, 6 Nov 2024 15:53:19 +0100
Subject: [PATCH 4/4] Clear Value, set DefaultValue instead

---
 NorsokSCDLibrary.aml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/NorsokSCDLibrary.aml b/NorsokSCDLibrary.aml
index 5d45fd1..b2ef4e1 100644
--- a/NorsokSCDLibrary.aml
+++ b/NorsokSCDLibrary.aml
@@ -15709,8 +15709,8 @@
           </Attribute>
           <Attribute Name="SignalClass" AttributeDataType="xs:string">
             <Description />
-            <DefaultValue />
-            <Value>Analogue</Value>
+            <DefaultValue>Analogue</DefaultValue>
+            <Value />
             <Constraint Name="LegalValues">
               <NominalScaledType>
                 <RequiredValue>Analogue</RequiredValue>