Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authentication layer #13

Open
joshghent opened this issue Oct 31, 2018 · 4 comments
Open

Add authentication layer #13

joshghent opened this issue Oct 31, 2018 · 4 comments
Assignees

Comments

@joshghent
Copy link
Contributor

joshghent commented Oct 31, 2018

Add passportjs with github strategy

@joshghent joshghent added the MVP Issues for the MVP label Nov 6, 2018
@joshghent joshghent added the good first issue Good for newcomers label Nov 15, 2018
@joshghent joshghent removed the good first issue Good for newcomers label Nov 22, 2018
@joshghent
Copy link
Contributor Author

@mct-dev Know you said you wanted to work on this next perhaps? Did you think to use OAuth rather than Passport?

@mct-dev
Copy link
Contributor

mct-dev commented Jul 1, 2019

@joshghent - I think passport is a good choice. I will start working on this task if you'd like, using passport to authenticate. Haven't worked with auth before, so I'd like to get some experience implementing it.

I would probably aim to complete this issue before continuing with #14, as well. You can feel free to add me as the "Assignee" to either task.

@joshghent joshghent assigned joshghent and mct-dev and unassigned joshghent Jul 1, 2019
@joshghent
Copy link
Contributor Author

@mct-dev Ok perfect, yeah that would be great if you did that. I'd really appreciate your time! Yes I think this is the one to do first, but don't mind you starting #14 as well since it might be helpful to test 👍Awesome work dude, thank you

@collinmesser collinmesser removed MVP Issues for the MVP up-for-grabs labels Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants