Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Core" lint in lint-staged mishandles staged file filtering #221

Open
luxaritas opened this issue May 2, 2023 · 0 comments
Open

"Core" lint in lint-staged mishandles staged file filtering #221

luxaritas opened this issue May 2, 2023 · 0 comments
Labels
priority: p3/standard Enhancement with nominal value or bug with nominal impact scope: lint-staged-utils size: sm type: bug Something isn't working

Comments

@luxaritas
Copy link
Member

  • When the micromatch matches none of the staged files, the eslint command is still run and is run on all files. It shouldn't run at all
  • We have a rule for package.json, but it isn't being included in the matcher
  • We may not need to do that filtering at all if we pass --no-error-on-unmatched-pattern when calling eslint
@luxaritas luxaritas added type: bug Something isn't working scope: lint-staged-utils size: sm priority: p3/standard Enhancement with nominal value or bug with nominal impact labels May 2, 2023
@luxaritas luxaritas changed the title "Core" lint in lint-staged mishandles staged file matching "Core" lint in lint-staged mishandles staged file filtering May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3/standard Enhancement with nominal value or bug with nominal impact scope: lint-staged-utils size: sm type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant