Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client: Failing engine-cancun Hive Tests: "ForkchoiceUpdatedV3 To Request Shanghai/Cancun Payload" #3690

Open
holgerd77 opened this issue Sep 20, 2024 · 3 comments

Comments

@holgerd77
Copy link
Member

We have several Hive engine tests failing, see e.g. here as some latest run.

Picking out the following failing tests:

grafik

These should be (I guess?) a somewhat easy fix, seems there is mainly the error code for some scenario wrong:

"FAIL (ForkchoiceUpdatedV3 To Request Shanghai Payload, Null Beacon Root): Expected error code on EngineForkchoiceUpdatedV3: want=-38003, got=-32602"

This might also be easiest to fix optimistically, so not to directly validate by setting up Hive (at least if one has not the setup locally and easily available) but just look at the scenario, give this a fix and see on next Hive run if things pass.

Note that there are more failing tests. Just picking out these ones to have one place for one type of failure to work on and eventually discuss and exchange.

@jochem-brouwer
Copy link
Member

I would not suggest to open a PR without running these tests locally in hive. When I get to this, I will write a setup guide here.

@holgerd77
Copy link
Member Author

Hmm, honestly: why not? Most of our bug fixing is done fully independent from Hive. And when Hive points to some misbehavior and we can confirm for ourselves this is misbehavior we can very well fix that without all the Hive setup?

@jochem-brouwer jochem-brouwer self-assigned this Sep 25, 2024
@jochem-brouwer
Copy link
Member

I have started on this (and have just assigned myself)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants