Skip to content
This repository has been archived by the owner on Apr 30, 2024. It is now read-only.

Add check when default built-in template is used in an open workspace from the Command Palette #79

Open
hughess opened this issue Jun 7, 2023 · 0 comments
Labels
review Requires additional testing and review

Comments

@hughess
Copy link
Member

hughess commented Jun 7, 2023

Original comment in #75 from @RandomFractals:

The scenario @archiewood described requires a check when the default built-in /template added in #62 is used in an open workspace from the Command Palette... and extension creating new project at the root of that open workspace (#48).

See #72 for more info and just add a check if the root open workspace folder has any files using the code snippets you have above before we copy all the files and subfolders from the built-in /template that ships with your extension to the 1st workspace folder in the open workspace. It should be added in the new src/fsUtils.ts/copyFiles() method used to copy template files to the open workspace root folder: https://github.com/evidence-dev/evidence-vscode/blob/main/src/utils/fsUtils.ts#L78 or on this line in that .ts file: https://github.com/evidence-dev/evidence-vscode/blob/main/src/utils/fsUtils.ts#L47

This was a last minute feature we flipped before releasing your v1.1.0 Evidence dev onboarding extension features and enhancements

You should be able to easily patch it and release v1.1.1 patch after bumping your ext. v. in package.json and providing the missing open workspace folder condition for one or both of the described cases (#72 & #62 while using #48 with #2).

We hope the notes shared in this comment will help your resolve this quickly as we move on to our next. 🤗

@hughess hughess added the review Requires additional testing and review label Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
review Requires additional testing and review
Projects
None yet
Development

No branches or pull requests

1 participant