Replies: 2 comments 20 replies
-
|
@Deathemonic wanna do some collab on somthing or u only want to rewrite pywal? cuz trust me i'm the first one who will say the codebase needs cleaning and that some parts of it are natural disasters... |
Beta Was this translation helpful? Give feedback.
-
|
I thought about wallust about how it's written in rist but the problem is the lack of backend it has I think the solution for that is just to use like a python bridge to make it so rust reads python I think pyo3 does that. But I think python3.11 should do fine with this new project. For the material you backend I suggest I was referring adding support for monet color theming for the project which is similar to gradience monet option, I think this library should be work with that "material-color-utilities-python" but the problem of this library is just the translation of the JavaScript version of that same library which makes it really slow and unoptimized. I was thinking of forking that library and optimized it. As for the custom number color palette I was thinking of having the user able to set how many colors it can output we can make it into a option or a config option but compromised the low quality of the colors because it skips the saturation calculation and we can make 16 pallette just to the saturation calculation. And back to the monet color output I don't know if we should pre-calculate the shades and saturation of that or just skip it output it to 16 pallettes or just output the actual pallettes I think it could be set as a option toggle in the config file https://github.com/T-Dynamos/materialyoucolor-pyhton As for the math of the project, the original pywal math is something, I think we can improve it using numpy and numba but i think numpy should work As for the custom kill script we can have like a function that uses kill like: def custom_kill(cmd):
# a split logic here were we split the string into list for a safer execution
subprocess.run(['kill', cmd]) # just a concept on how should workSomething like that and we can add a config option for it: or we can make it restart it and if there is like a custom start command in case someone starts there program with a script we can just add the path of the script and the new "pywal" should do the rest. I am looking more into how I can explore it with the custom kill script system Then for the custom wallpaper engine, you know there like a alot of wallpaper setters like swww, swaybg, feh, nitrogen how about we make it into a config option like: we could have a default setting in case the user doesn't set it. But I don't think video wallpaper engine should be allowed we can have like it sets the wallpaper but can't provide the pallet because it is a unsupported format For the configuration file I was thinking more like wallust but different maybe we can use it as a new template system but idk. We can use the configuration file as a option save so the user doesn't have to input the options into the cli Gtk and QT on the other hand probably hard to do cause it requires modifying the actual theme but I love to see how you tackle it Another one is for making different function of the project to be libraries but I don't think it would be viable for this project unless the project will get big But we should prioritize the base of the project first I would like to hear your thoughts about this |
Beta Was this translation helpful? Give feedback.
-
|
also i saw this project https://github.com/NicklasVraa/Color-manager I was thinking maybe this could work on changing the svg of the themes easily but im thinking of other themes or we just stuck with a custom theme like gradience which requires adw-gtk3 in order for the theming will work on gtk3 |
Beta Was this translation helpful? Give feedback.
-
|
also idk what should we call this new "pywal" |
Beta Was this translation helpful? Give feedback.
-
|
For template idk if we should keep it just as it was How we can do this template system, so no need to manually store templates in the codebase? One Is use wpgtk template method https://github.com/deviantfero/wpgtk/wiki/Templates Were we input the file we need to change into a template like the problem with that we have to symlink were the path is, im thinking how about add a keywords called and to backup it we just copy the original file to So it should look like this: Manual: >>> mkdir ~/.config/project/templates
>>> touch ~/.config/project/templates/rofi.rasi.baseThis will write the The file is processed automatically and removes the path keywords and the escape characters And for cli we can put a option CLI: This should automatically create a Also we can add custom keywords just like wpgtk https://github.com/deviantfero/wpgtk/wiki/Custom-Keywords This should allows more freedom on how we change the theme. I would like to hear your thoughts about this |
Beta Was this translation helpful? Give feedback.
-
|
sorry for taking so long to answer, lots of stuff have distracted me. for the plans, i want to get pywal16 3.5.0 out this month and into pypi to serve as a stopgap until we can have the first release of pywal reloaded out. about languages i'm personally against the use of rust for the pywal usecase, pywal is not a program intended to be ran a lot of times per second, so performance isn't relevant, also i'm not familiar with rust, i'd like to have the same backends as pywal currently has, a default backend that works with very little stuff (just imagemagick, tho i've looked into supporting graphics magick but is a headache), and have as little external dependencies as possible. about the math, yes in pywal it is terrible, i'm not against using a library there, however i think it can be made more predictable. for the material colors and monet, looking at the material colors library we may as well implement our own based on that one, monet we can add as just another backend like colorthief/fast_colorthief and colorz. for custom scripts, configs and wallpaper setters, pywal's current approach is not great and is largely not documented but ain't as bad as could be, pywal has the -o option to run an external script after pywal, perhaps keeping something like that, maybe just specify a custom script to run in a config file so that the users can simply supply their own if they need to reload or restart anything. for the wallpaper setting, sadly pywal has set the precedent of it working "auto-magically" unless the "-n" option is used, so asking the user to provide a custom wallpaper setting command by default would seem a regression... for configuration i'm not sold on toml, i'm personally used to having the ability to script my configs in lua or at the very least shell script... at least with pywal i never really used Qt and Gtk are a headache, i've seen many ways to deal with them but the least terrible seems to be what gradience does, use a gtk3 theme that matches the gtk4 visual style, apply colors to both, now to get QT to match is more than just colors, it should also match in style, ideally i would have 2 scripts that can take a colorscheme (be it in json or any other method), construct the color theme for gradience, other that takes a gradience theme and a kvantum theme template or even any kavantum theme and a dictionary of what colors should replace for what gradience theme entries, replace them, export the theme files, then set the kvantum theme. i'm aware of color manager and similar projects, not that i'm not considering them but i would leave that for after we got the new "pywal" working as for name, any name can do, pywal-reloaded, neo-pywal, npywal, that's secondary to the program working. templating systems aren't easy, pywal's templating system is the bare minimum, wpgtk i feel can get somewhat confusing, that is why i don't want to concentrate on a templating system now and i'd rather make it a module that the new pywal can work without until we figure something that works in a not cumbersome way. |
Beta Was this translation helpful? Give feedback.
-
|
Hi, I wrote https://github.com/luisbocanegra/kde-material-you-colors which uses https://github.com/avanisubbiah/material-color-utilities-python to get the colors from the plasma wallpaper Then uses a big (dbus/some plasma cli tools) mess to apply the colors to Plasma/Konsole using their color scheme system, both made with hardcoded templates in code, it also uses even more questionable logic to get material colors applied to pywal (normal,intense,faint) Basically using this as the source for colorsI don't know if my skills are up to the task but I would be interested in adding the material backend using https://github.com/T-Dynamos/materialyoucolor-python to pywal or the new "pywal". If the material backend were to be added, could the schemes(dark/light) and palettes(tones 0-99) be considered for using them in the templates? It could be interesting to allow picking a color from either the material scheme or any tone of each palette. The only problem I see is other color extraction backends don't provide this much amount of colors, could that be addressed by having material you specific templates? Some other things about material you and how I used it in kde-material-you-colors:
|
Beta Was this translation helpful? Give feedback.
-
I was thinking the same
Yeah, the reason I have both is to theme plasma with light and everything else dark
Actually, an image may have a small amount of color, yet if the algorithm thinks it is not fit for generating themes it will return the color scheme but with the pixel blue as the source as if the wallpaper itself was blue, I think it may be possible to allow the scorer to return unchromatic colors and then tell the scheme generator to use the gray variant if the seed is gray. Will have to look into this.
Maybe, I think separate material you template is best for that, the regular backends generate 16 colors and the material one the 16 colors + scheme + tonal palettes to be used in templates.
So a plugin be used to apply the colors from a template for plasma (like a reload thing), for example?
Yeah, I was planning switching back to the JS implementation to get the scheme variants in kde-material-you-colors because I wasn't interested in updating avanisubbiah/material-color-utilities-python I had a draft PR calling node from python, not good. |
Beta Was this translation helpful? Give feedback.
-
Yep, looks like the repainter.app/themes are scheme variants but with different chroma parameters/seed color, but haven't used that app in a while so not sure. The pre-defined scheme variants (or color profiles) could be passed to like this |
Beta Was this translation helpful? Give feedback.
-
Example on how it should work: import Pywal
p = Pywal(wal='/some/wall', monet=True)
p.template(base='/base/file')
p.reload() |
Beta Was this translation helpful? Give feedback.
-
Hmm I'll take a look at the code and try to make a draft sometime soon™
Thanks I get it now, yeah that could be really useful |
Beta Was this translation helpful? Give feedback.
-
|
For now we just need a base code for basic stuff, We just have to get the basic part like set wallpaper then output the colors using colorthief for now |
Beta Was this translation helpful? Give feedback.
-
for things that aren't actual issues
feel free to cast opinions and hot takes, even badmouth the way that pywal is written (i do it whenever i'm actually working on it)
Beta Was this translation helpful? Give feedback.
All reactions