Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AmigaRpdo1 / AmigaTpdo1 proto defintiions #20

Open
Hackerman342 opened this issue Nov 3, 2022 · 0 comments
Open

AmigaRpdo1 / AmigaTpdo1 proto defintiions #20

Hackerman342 opened this issue Nov 3, 2022 · 0 comments
Assignees
@ethanrublee @Hackerman342
Labels
enhancement New feature or request

Comments

@Hackerman342
Copy link
Collaborator

Potential feature:
Add proto definitions for the AmigaRpdo1 / AmigaTpdo1 packets in https://github.com/farm-ng/amiga-brain-api/blob/main/py/farm_ng/canbus/packet.py

This would allow them to be used easily in both python and c++.

We would then add simple conversion functions from AmigaRpdo1 proto to and from RawCanbusMessage. Also, our canbus service could implement an amiga specific grpc layer where one could subscribe directly to the AmigaTpdo1, for example.

cc @ethanrublee
@Hackerman342 Hackerman342 added the enhancement New feature or request label Nov 3, 2022
@Hackerman342 Hackerman342 changed the title AmigaRpdo1 / AmigaTpdo1 proto defintiions AmigaRpdo1 / AmigaTpdo1 proto defintiions Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethanrublee ethanrublee

@Hackerman342 Hackerman342

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ethanrublee @Hackerman342