Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "missing face" bug #1

Open
fgerlits opened this issue Nov 4, 2019 · 0 comments
Open

Fix "missing face" bug #1

fgerlits opened this issue Nov 4, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@fgerlits
Copy link
Owner

fgerlits commented Nov 4, 2019

If a 2-dimensional face lies in the hyperplane but neither of the two adjacent 3-dimensional faces do, we don't make this face part of the intersection. This can result in an intersection with a hole in the middle. There is already a FIXME about this in ThreeDimensionalFace.java.

To reproduce: from the initial position, turn the xy slider to exactly (+ or -) 45°. This is where the color of the face changes. If you find the point at exactly 45°, you'll get a tunnel with a hole in the middle.

Proposed solution: in cases like this, draw the face with a mixture of the colors of the two 3-dimensional faces. This would also help in the case when a complete 3-dimensional face is in the hyperplane: the cube would no longer be all the same color, so hard to see.

@fgerlits fgerlits added the bug Something isn't working label Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant