Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window icon missing under Wayland #87

Open
subpop opened this issue Mar 5, 2022 · 5 comments
Open

Window icon missing under Wayland #87

subpop opened this issue Mar 5, 2022 · 5 comments

Comments

@subpop
Copy link

subpop commented Mar 5, 2022

Running the QOwnNotes flatpak under a Plasma Wayland session results in a generic Wayland icon in the taskbar.

image

I understand this to be the result of a mismatched .desktop file name (see this blog post. I believe QOwnNotes upstream has fixed this issue by renaming the desktop file to PBE.QOwnNotes.desktop (see upstream issue #993). I think maybe the renaming of the desktop file based on the org.qownnotes.QOwnNotes flatpak app-id might be breaking the ability to look up the application icon for the taskbar.

@Erick555
Copy link
Contributor

Erick555 commented Mar 5, 2022

I guess upstream needs to move from PBE.QOwnNotes.desktop to org.qownnotes.QOwnNotes and change OrganizationDomain accordingly. Or resubmit app to flathub under different name.

@pbek
Copy link
Collaborator

pbek commented Mar 6, 2022

and change OrganizationDomain accordingly

that would break all settings

Or resubmit app to flathub under different name.

@stobbsm?

@subpop
Copy link
Author

subpop commented Mar 7, 2022

Regardless of what upstream does in the long term, wouldn't it make sense for the downstream flatpak to patch the OrganizationDomain to org.qownnotes.QOwnNotes to avoid this mismatch with its current app-id?

@Erick555
Copy link
Contributor

Erick555 commented Mar 7, 2022

In the comment above it was said it would break all settings for existing users which makes it an unfavorable change.

@walking-octopus
Copy link

walking-octopus commented Nov 4, 2023

Was there any progress on this? Both Flatpak and Wayland are increasingly becoming the default for many distros, especially the immutable distros like Silverblue where Flatpak is basically the only well-supported option, and this bug can be rather annoying to users who use Super+Number to switch between windows.

After trying to mess with Flatpak's .desktop files, I realized it won't apply my change to StartupWMClass, Thankfully, KDE has a nice Window Rules feature that can match all PBE.QOwnNotes windows and force their class to be set to QOwnNotes, fixing the issue.

While it is a much nicer temporary solution than just seeing Wayland icons everywhere, it still is just a hack. Regular users may not know or what to spend time implementing such workarounds just to fix a mildly annoying packaging bug. I'm putting it out there so that everyone in the same situation can avoid wasting their time in the future.

Screenshot_20231104_122112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants