Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: make it possible to add idioms via text to lexeme #189

Open
dpriskorn opened this issue Feb 8, 2024 · 3 comments · May be fixed by #196
Open

Feature request: make it possible to add idioms via text to lexeme #189

dpriskorn opened this issue Feb 8, 2024 · 3 comments · May be fixed by #196

Comments

@dpriskorn
Copy link

dpriskorn commented Feb 8, 2024 •
edited
Loading

Change select to input field with max two lengh
This way I would be able to tune to the number of ngram needed by entering a number.

Try e.g. this Danish proverb input where 10 would be needed:
Den der kommer først til mølle, får først malet.
Man skal ikke kaste med sten når man selv bor i glashus.
Én fugl i hånden er bedre end ti på taget.
Tomme tønder buldrer mest.
Man skal ikke gå over åen efter vand.
Brændt barn skyr ilden.
Når katten er ude, spiller musene på bordet.
@dpriskorn
Copy link
Author

dpriskorn commented May 31, 2024 •
edited
Loading

There is a max-n-gram parameter which might enable what I want

ordia/ordia/app/views.py

Line 550 in a528662

max_n_gram = request.args.get('max-n-gram')

@dpriskorn
Copy link
Author

dpriskorn commented May 31, 2024 •
edited
Loading

This restriction must be removed if idioms and proverbs longer than 3 words are to be curated via text-to-lexemes:

ordia/ordia/app/views.py

Line 576 in a528662

# Currently confined to between 1 and 3

@fnielsen

dpriskorn added a commit to dpriskorn/ordia that referenced this issue May 31, 2024
@dpriskorn
fix: Remove n-gram restriction.
2d14f06 
fixes fnielsen#189
@dpriskorn dpriskorn linked a pull request May 31, 2024 that will close this issue
Open
@fnielsen
Copy link
Owner

This restriction must be removed if idioms and proverbs longer than 3 words are to be curated via text-to-lexemes:

ordia/ordia/app/views.py

Line 576 in a528662

# Currently confined to between 1 and 3

@fnielsen

This was a concern about overloading the server with large max_n_gram.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Remove n-gram restriction. dpriskorn/ordia
2 participants
@fnielsen @dpriskorn