Upgrade codemirror with new parser #2980
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Sergio A. Vargas <[email protected]>
Try this Pull Request!Open Julia and type: julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="codemirror-savq")
julia> using Pluto |
Co-Authored-By: Sergio A. Vargas <[email protected]>
|
@savq mabye you could help with updates to lezer_template and scopestate_statefield? I think the rest is easy enough for me :) |
|
This PR got stuck because of the pattern matching code by dralletje. I gave it a try but this is way to hard to update, I'm declaring it unmaintainable! Since we barely use the pattern matching and scopestate system, I will look into removing it and rewriting functionality into simpler (less precise) tree traversal code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@savq did incredible work on the Julia parser! JuliaPluto/lezer-julia#7
Fix #2943