-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropdown should have a top margin of 0.5px #163
Comments
Excuse me, I have a silly question. How do I test my solution? |
You can run |
That's strange. I'm sorry if this is too obvious, but did you run |
I didn't see those addons listed in package.json directly either, but it's fairly probably that it must have been bundled with something else. |
Description
The
Button
component has a top margin of 0.5px whileDropdown
doesn't. When Button and Dropdown are used together:Page tested: https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures/basic-javascript/comment-your-javascript-code
Changes needed
To address the issue, I think
Dropdown
should have a 0.5px top margin.Though we might want to revisit this in the future,
Button
orDropdown
probably shouldn't have any margin, and their parent should be responsible for the layout (ref #13).The text was updated successfully, but these errors were encountered: