Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Check all conditionals for on-hit effects and exclude from combat stats #410

Open
63 tasks
fribbels opened this issue Jun 6, 2024 · 0 comments
Open
63 tasks

Comments

@fribbels
Copy link
Owner

fribbels commented Jun 6, 2024

Motivation

  • Some buff effects are not actually combat stats, but rather trigger only on hit without adding to the character's stats. For example, crit rate buffs from Wastelander. This means our set activation might be incorrect in cases like Rutilant/etc

Goal

  • Revisit all the conditionals, figure out which ones are on-hit effects and which ones are not, then patch the damage calculations to account for this disparity. Potentially introduce a third view for Basic / Combat / On-Hit?
  • Acheron
  • E1 on-hit CR
  • Trace 3 turn DMG
  • Argenti
  • Trace 15% on-hit DMG
  • Arlan
  • Asta
  • Aventurine
  • Ult on-hit CD
  • Bailu
  • Black Swan
  • Blade
  • Boothill
  • Bronya
  • Clara
  • Dan Heng
  • E1 on-hit CR (?)
  • Dan Heng • Imbibitor Lunae
  • Trace on-hit CD (?)
  • Dr. Ratio
  • Trace on-hit DMG -----------
  • Feixiao
  • Firefly
  • Fu Xuan
  • Gallagher
  • Gepard
  • Guinaifen
  • Hanya
  • Herta
  • Himeko
  • Hook
  • Huohuo
  • Jade
  • Jiaoqiu
  • Jing Yuan
  • Jingliu
  • Kafka
  • Lingsha
  • Luka
  • Luocha
  • Lynx
  • March 7th
  • March 7th
  • Misha
  • Moze
  • Natasha
  • Pela
  • Qingque
  • Rappa
  • Robin
  • Ruan Mei
  • Sampo
  • Seele
  • Serval
  • Silver Wolf
  • Sparkle
  • Sushang
  • Tingyun
  • Topaz & Numby
  • Trailblazer
  • Trailblazer
  • Trailblazer
  • Trailblazer
  • Trailblazer
  • Trailblazer
  • Welt
  • Xueyi
  • Yanqing
  • Yukong
  • Yunli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

No branches or pull requests

1 participant