Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview displays broken images if files are not images #25

Open
kmiyashiro opened this issue Jan 21, 2016 · 1 comment
Open

Preview displays broken images if files are not images #25

kmiyashiro opened this issue Jan 21, 2016 · 1 comment

Comments

@kmiyashiro
Copy link
Contributor

Currently preview does not support non-image files and displays a broken image. Ideally it would display the file name and size, or some other reasonable default.

@jelhan
Copy link
Contributor

jelhan commented Feb 12, 2016

We could also display a preview if it's a text file using canvas. There seem to be many use cases where users should upload text files (logs, csv etc.). Could fall back to file name and size if it's a binary file but not an image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants