Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a fyne.Do method for developers #5392

Merged
merged 4 commits into from
Jan 11, 2025

Conversation

andydotxyz
Copy link
Member

and update our naming/docs

Testing the threading model is a separate PR as it refers to the driver work not this top level package change.

Nearing the end of #4654

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.
  • Public APIs match existing style and have Since: line.

@coveralls
Copy link

coveralls commented Jan 11, 2025

Coverage Status

coverage: 59.181% (-0.05%) from 59.228%
when pulling 82e2aa5 on andydotxyz:feature/invoke
into 2355f9d on fyne-io:develop.

Jacalz
Jacalz previously approved these changes Jan 11, 2025
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the new API but let's hear what the other think first :)

// Since: 2.6
CallFromGoroutine(func())
DoFromGoroutine(func())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to un-export this one for public use to avoid confusion, so we just have fyne.Do? Or at least have the documentation here make clear that it is entirely equivalent to calling fyne.Do and fyne.Do should generally be preferred (for brevity and for standardization)?

thread.go Outdated Show resolved Hide resolved
@andydotxyz andydotxyz merged commit 9d4dce9 into fyne-io:develop Jan 11, 2025
12 checks passed
@andydotxyz andydotxyz deleted the feature/invoke branch January 11, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants