Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gz-gui8] Fails to build MinimalScene if gz-rendering8 is built without vulkan support #585

Closed
oysstu opened this issue Oct 9, 2023 · 2 comments
Assignees

Comments

@oysstu
Copy link

oysstu commented Oct 9, 2023

The vulkan external device header is guarded by GZ_RENDERING_HAVE_VULKAN
https://github.com/gazebosim/gz-rendering/blob/22b2bbfbe06ac68558d77948d339fbc294876c85/include/gz/rendering/RenderEngineVulkanExternalDeviceStructs.hh#L27-L63

This is essentially only set for builds using OGRE2/ogre-next and vulkan support.
https://github.com/gazebosim/gz-rendering/blob/22b2bbfbe06ac68558d77948d339fbc294876c85/CMakeLists.txt#L134-L159

The build therefore fails for gz-rendering8 with only ogre 1.9 or non-vulkan ogre-next.

Edit: due to the following include

#include <gz/rendering/RenderEngineVulkanExternalDeviceStructs.hh>

@jennuine
Copy link
Contributor

@iche033 do you mind to take a look?

@jennuine
Copy link
Contributor

jennuine commented Oct 18, 2023

Fixed with #589, thanks @iche033 !

@github-project-automation github-project-automation bot moved this from Inbox to Done in Core development Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants