Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAX interface simulations #1067

Closed
simbilod opened this issue Jan 3, 2023 · 2 comments
Closed

SAX interface simulations #1067

simbilod opened this issue Jan 3, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@simbilod
Copy link
Collaborator

simbilod commented Jan 3, 2023

See #13 in SAX

How easy would it be for sax.circuit to also account for interfaces between components?

I am thinking a flag that, if True,
(1) requires the user to provide models for component pairs that show up connected in the graph
(2) adds a component evaluating these models at every "connection" of the netlist

The obvious use case is to model reflections in direct transitions between waveguides with different widths or bend radii. Currently gdsfactory+SAX throws a critical warning for the former, and evaluates the second without mode mismatch reflections.

Maybe this should be added as an option in gdsfactory.get_netlist()?

Example behaviour for bend --> coupler --> straight :

Input:
circuit, _ = sax.circuit(c.get_netlist(), models=models, interfaces=True)
Output:

"Given Models": [],
"Required Models": ["bend_circular", "coupler_full", "straight"],
"Required Interface Models": [("bend_circular", "coupler_full"), ("bend_circular", "straight")],

If there were open-source EMEs around the required overlap matrices would be very easy to calculate :)

@simbilod simbilod added the enhancement New feature or request label Jan 3, 2023
@tvt173
Copy link
Collaborator

tvt173 commented Feb 20, 2023

@simbilod, I would argue that transitions between different cross-sections, like the example you give, should be captured and modeled as their own components. this would get rid of the issue you raise. and would also make it easier to validate that all connections in your circuit are proper. what do you think?

@simbilod
Copy link
Collaborator Author

@simbilod, I would argue that transitions between different cross-sections, like the example you give, should be captured and modeled as their own components. this would get rid of the issue you raise. and would also make it easier to validate that all connections in your circuit are proper. what do you think?

Yes I think that is probably the best thing to do at the gdsfactory level. There was interest in implementing something like this as an option in SAX directly (see linked issue), but I haven`t had time to wrap it up yet.

Anyway, I will close this for now in this repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants