Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#'build-finite-ss launches interactive inspector #151

Open
jcguu95 opened this issue Jan 5, 2025 · 1 comment
Open

#'build-finite-ss launches interactive inspector #151

jcguu95 opened this issue Jan 5, 2025 · 1 comment

Comments

@jcguu95
Copy link

jcguu95 commented Jan 5, 2025

In the manual, we expect #'build-finite-ss to return an object.

(setf cylinss (build-finite-ss
    '(v0 v1
      1 e0 (v1 v0) e1 (v1 v1) e2 (v0 v0) e3 (v1 v0)
      2 t0 (e1 e3 e0) t1 (e0 e3 e2)) ))  ==>

[K2 Simplicial-Set]

However, its source code uses inspect, which on sbcl launches an interactive session. I suggest to change inspect to describe to keep alignment with the description in the manual.

(DEFUN BUILD-FINITE-SS (list)
  (declare (list list))
  (let ((bspn (first list))
        (table (finite-ss-table list))
        (ind-smst (gensym)))
      [..]
      (setf (symbol-value ind-smst) rslt)
      (inspect rslt)   ;; use DESCRIBE instead
      [..]
      rslt)))
@adlai
Copy link

adlai commented Jan 6, 2025

CL:DESCRIBE clutters public streams; at the very least, dirty *debug-io*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants