-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory issues when trying to save large pages #42
Comments
It looks like there is a memory issue. Can you confirm you did not change any setting and your version of SingleFileZ is the latest one? |
SingleFileZ v 0.5.25 |
Thank you. Is the page very large? Could you post a URL that illustrates this issue? To see how large the page is, you can press F12, refresh the page and reset the cache by pressing shift+refresh button, go to the "Network" tab in the debugger and read the total of transferred bytes. |
Thank you for the test. So, it looks like it's indeed related to the size of the page. I'm not sure I can optimize the memory consumption but there's some hope. It's not a trivial task though and it will need some work on my end. Could you tell me if you can save the page with SingleFile or if it crashes too? |
I guess it works. Thanks for the info! |
@mr1pacman I just published the version 0.5.26 which is supposed to fix this issue on the store of Firefox. It will be available in approximately 4-7 days on the store of Chrome. Do not hesitate to test it and tell me if it fixes the issue. |
Too bad... I don't know why in your screenshot the icon displays "ERR". Could you please go to about:debugging#/runtime/this-firefox, scroll down to the entry for SngleFileZ in the list, click on the button "Inspect" and post a screenshot of what you're seeing in the console of the Inpect window. |
Thank you. Actually, I did not notice the "out of memory" issue present in the previous screenshot on #42 (comment). In the debugger of the page itself, could you please click on the arrow icon next to "out of memory" to expand the info about the error? |
Thank you. Unfortunately, the details do not help me (it's my fault) to understand what is causing the out of memory error. The procedure to install manually an extension is described here: https://extensionworkshop.com/documentation/develop/temporary-installation-in-firefox/ I'm really sorry for all the tests I'm asking you to do. If this custom version does not fix the issue, I'll try to create a test page in order to reproduce it, and not bother you too much. |
Thank you. It looks like things are going a bit better since no errors are displayed now. What is displayed in the other debugger? cf #42 (comment) |
Note that HTML pages (and all text resources) are always converted into UTF-8. That's why there is no encoding declaration. I don't think this warning is related to the issue. |
FYI, I published the last fix because it looks like it makes things better even it the issue is still present. |
Interesting... Does the error happen with the version 0.5.24 as well? |
Could you also test this version and tell me if it fixes the issue? |
@mr1pacman The version I just published should fix your last issue in Firefox. |
windows 7 x64 Firefox
i5 650. 16 gb RAM
p.s. Google Chrome crashes tab
The text was updated successfully, but these errors were encountered: