Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory issues when trying to save large pages #42

Open
mr1pacman opened this issue Mar 14, 2020 · 25 comments
Open

Memory issues when trying to save large pages #42

mr1pacman opened this issue Mar 14, 2020 · 25 comments

Comments

@mr1pacman
Copy link

mr1pacman commented Mar 14, 2020

iHp6wvt4dfA
windows 7 x64 Firefox
i5 650. 16 gb RAM

p.s. Google Chrome crashes tab

@gildas-lormeau
Copy link
Owner

gildas-lormeau commented Mar 14, 2020

It looks like there is a memory issue. Can you confirm you did not change any setting and your version of SingleFileZ is the latest one?

@mr1pacman
Copy link
Author

SingleFileZ v 0.5.25
setting default

@gildas-lormeau
Copy link
Owner

gildas-lormeau commented Mar 14, 2020

Thank you. Is the page very large? Could you post a URL that illustrates this issue?

To see how large the page is, you can press F12, refresh the page and reset the cache by pressing shift+refresh button, go to the "Network" tab in the debugger and read the total of transferred bytes.

@mr1pacman
Copy link
Author

Снимок
The web page contains a book. If about 600-700 pages - crash / error
If about 300-400 - no problem

@gildas-lormeau
Copy link
Owner

Thank you for the test.

So, it looks like it's indeed related to the size of the page. I'm not sure I can optimize the memory consumption but there's some hope. It's not a trivial task though and it will need some work on my end. Could you tell me if you can save the page with SingleFile or if it crashes too?

@mr1pacman
Copy link
Author

Снимок

@gildas-lormeau
Copy link
Owner

I guess it works. Thanks for the info!

@gildas-lormeau
Copy link
Owner

@mr1pacman I just published the version 0.5.26 which is supposed to fix this issue on the store of Firefox. It will be available in approximately 4-7 days on the store of Chrome. Do not hesitate to test it and tell me if it fixes the issue.

@mr1pacman
Copy link
Author

3HIkyCCxijY

@gildas-lormeau
Copy link
Owner

Too bad... I don't know why in your screenshot the icon displays "ERR". Could you please go to about:debugging#/runtime/this-firefox, scroll down to the entry for SngleFileZ in the list, click on the button "Inspect" and post a screenshot of what you're seeing in the console of the Inpect window.

@mr1pacman
Copy link
Author

ezl9whIXuOg
VUY1iHxfoWA

@gildas-lormeau
Copy link
Owner

Thank you. Actually, I did not notice the "out of memory" issue present in the previous screenshot on #42 (comment). In the debugger of the page itself, could you please click on the arrow icon next to "out of memory" to expand the info about the error?

@mr1pacman
Copy link
Author

Снимок

@gildas-lormeau
Copy link
Owner

gildas-lormeau commented Mar 15, 2020

Thank you. Unfortunately, the details do not help me (it's my fault) to understand what is causing the out of memory error.
Can you install manually the version extension I attached and do the same test? It might fix the issue or give me more details about the cause of the error.

The procedure to install manually an extension is described here: https://extensionworkshop.com/documentation/develop/temporary-installation-in-firefox/
The zip file of the extension to test: singlefilez-extension-firefox.zip

I'm really sorry for all the tests I'm asking you to do. If this custom version does not fix the issue, I'll try to create a test page in order to reproduce it, and not bother you too much.

@gildas-lormeau gildas-lormeau changed the title Don't Work Memory issues when trying to save large pages Mar 15, 2020
@mr1pacman
Copy link
Author

zVOZC4jgg7Q

@gildas-lormeau
Copy link
Owner

gildas-lormeau commented Mar 15, 2020

Thank you. It looks like things are going a bit better since no errors are displayed now. What is displayed in the other debugger? cf #42 (comment)

@mr1pacman
Copy link
Author

gsp6Wx4_yHQ
-ivL_e0zRng
YBBkO-zyNts
Translate: The HTML document does not contain character encoding declarations. If the document contains characters that are not in the US-ASCII range, then in some embodiments, the character encoding must be declared in the document or in the transmission protocol.

@gildas-lormeau
Copy link
Owner

gildas-lormeau commented Mar 15, 2020

Note that HTML pages (and all text resources) are always converted into UTF-8. That's why there is no encoding declaration. I don't think this warning is related to the issue.
The protobuf warning is expected and no errors are displayed now. But it still does not work. I think I need to create my own test file in order to see what's wrong.

@gildas-lormeau
Copy link
Owner

FYI, I published the last fix because it looks like it makes things better even it the issue is still present.

@mr1pacman
Copy link
Author

1vyDE2ouzLc
9fD1ESfYP88
Ge_GMY3EXVA

@mr1pacman
Copy link
Author

new error, small page
rOO1NyciSQU

@gildas-lormeau
Copy link
Owner

Interesting... Does the error happen with the version 0.5.24 as well?

@gildas-lormeau
Copy link
Owner

Could you also test this version and tell me if it fixes the issue?

singlefilez-extension-firefox.zip

@mr1pacman
Copy link
Author

mr1pacman commented Mar 17, 2020

last version on Firefox
no, dont work
p.s. on Google Chrome (last version)
ecCTYeTsA60

@gildas-lormeau
Copy link
Owner

gildas-lormeau commented Mar 18, 2020

@mr1pacman The version I just published should fix your last issue in Firefox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants