Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Books need Covers #5

Open
7 of 8 tasks
sethwoodworth opened this issue Jul 27, 2015 · 14 comments
Open
7 of 8 tasks

Books need Covers #5

sethwoodworth opened this issue Jul 27, 2015 · 14 comments
Assignees

Comments

@sethwoodworth
Copy link
Contributor

Recovering the Classics has offered us a CC-by-nc license to their covers. They have provided a books.json file in a (currently private) github repo.

  • map RTC books.json to our book list spreadsheet
  • loop over all repos in this collection (see: this feature: Get public domain book descriptions for metadata gitberg#7)
  • fetch cover file from rawgit with github login
    • get missing covers from Jenny (ETA: Tomorrow)
  • keep file as jpg (or convert from png if necessary) and add to repo as cover.jpg
  • update the htmlbook templates to handle cover.jpg
  • add attribution/copyright from books.json
  • make travis read this metadata
@sethwoodworth
Copy link
Contributor Author

In books.json first book in the list of covers is the one we're using.

@sethwoodworth
Copy link
Contributor Author

Now we're going to modify the xslt, travis file (maybe asciidoctor-htmlbook?) to use jpg

@eshellman
Copy link
Contributor

Alternatively, change to jpeg and deal with parameterizing the cover file name into xslt later.

@rdhyee rdhyee self-assigned this Jul 27, 2015
@rdhyee
Copy link
Contributor

rdhyee commented Jul 27, 2015

My next step -- update the cover at GITenberg/Adventures-of-Huckleberry-Finn_76: Adventures of Huckleberry Finn by Twain, Mark, 1835-1911 is a Project Gutenberg book, now on Github. on GitHub to jpg and update the template accordingly and make sure the travis build still works.

@rdhyee
Copy link
Contributor

rdhyee commented Jul 27, 2015

Should we use the big covers or the small covers?

@sethwoodworth
Copy link
Contributor Author

Big covers, we can resize down later
On Jul 27, 2015 1:57 PM, "Raymond Yee" [email protected] wrote:

Should we use the big covers or the small covers?


Reply to this email directly or view it on GitHub
#5 (comment)
.

@rdhyee
Copy link
Contributor

rdhyee commented Jul 27, 2015

Any objection to "cover.jpg" (as opposed to "cover.jpeg")?

@jenny8lee
Copy link

cover.jpg is more consistent with our other eBooks, so I would go with that
over cover.jpeg.

On Monday, July 27, 2015, Raymond Yee [email protected] wrote:

Any objection to "cover.jpg" (as opposed to "cover.jpeg")?


Reply to this email directly or view it on GitHub
#5 (comment)
.

@rdhyee
Copy link
Contributor

rdhyee commented Jul 27, 2015

Thanks @jenny8lee

@eshellman
Copy link
Contributor

What do you think about adding RTC to the publisher attribute?

publisher: Project Gutenberg and Recovering the Classics

This would have the side effect of letting us use a Publisher-specific OPDS feed to provide RTC flavored books to NYPL.

@eshellman
Copy link
Contributor

I'll start a "sizing covers" issue separately

@jenny8lee
Copy link

You will need to acknowledge RTC in the metadata somehow. Publisher seems
fine. Open to other places.

On Thu, Jul 30, 2015 at 12:03 PM, eshellman [email protected]
wrote:

What do you think about adding RTC to the publisher attribute?

publisher: Project Gutenberg and Recovering the Classics

This would have the side effect of letting us use a Publisher-specific
OPDS feed to provide RTC flavored books to NYPL.


Reply to this email directly or view it on GitHub
#5 (comment)
.

@rdhyee
Copy link
Contributor

rdhyee commented Jul 30, 2015

@eshellman. I don't see any problem with that approach. (I defer to you as the master of metadata.yaml). Can you prototype your suggestions in a non-master branch for https://github.com/GITenberg/Adventures-of-Huckleberry-Finn_76/ so we can examine it concretely?

@eshellman
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants