Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS: Fix crash in case of string literal in export specifier #18452

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

asgerf
Copy link
Contributor

@asgerf asgerf commented Jan 9, 2025

Fixes #18336

@asgerf asgerf marked this pull request as ready for review January 9, 2025 13:04
@Copilot Copilot bot review requested due to automatic review settings January 9, 2025 13:04
@asgerf asgerf requested a review from a team as a code owner January 9, 2025 13:04

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • javascript/ql/test/library-tests/Modules/tests.expected: Language not supported

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more

@erik-krogh erik-krogh merged commit 70a1a64 into github:main Jan 9, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Literal cannot be cast Identifier" when processing new ECMAScript/TypeScript export/import syntax
2 participants