Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing actions in GitHub Marketplace appears to wrongly suggest Each repository must contain a single action #35437

Open
1 task done
Tracked by #35771 ...
jsoref opened this issue Nov 26, 2024 · 4 comments
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team SME reviewed An SME has reviewed this issue/PR

Comments

@jsoref
Copy link
Contributor

jsoref commented Nov 26, 2024

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/actions/sharing-automations/creating-actions/publishing-actions-in-github-marketplace

What part(s) of the article would you like to see updated?

Actions are published to GitHub Marketplace immediately and aren't reviewed by GitHub as long as they meet these requirements:

  • The action must be in a public repository.
  • Each repository must contain a single action.

I'm not sure this is a real requirement... At the very least, the GitHub Actions organization violates this:

GitHub codeql-action definitely doesn't conform to this:

At least Endor Labs Scan has multiple action.yml files

I certainly haven't seen anything preventing it.

Additional information

No response

@jsoref jsoref added the content This issue or pull request belongs to the Docs Content team label Nov 26, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 26, 2024
@nguyenalex836 nguyenalex836 added actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review needs SME This proposal needs review from a subject matter expert and removed triage Do not begin working on this issue until triaged by the team labels Nov 26, 2024
@nguyenalex836
Copy link
Contributor

@jsoref Thank you for raising this issue! I'll get this triaged for review ✨ Our team will provide feedback regarding the best next steps for this issue - thanks for your patience! 💛

Copy link
Contributor

Thanks for opening an issue! We've triaged this issue for technical review by a subject matter expert 👀

Copy link
Contributor

This is a gentle bump for the docs team that this issue is waiting for technical review.

@github-actions github-actions bot added the SME stale The request for an SME has staled label Dec 25, 2024
@nguyenalex836 nguyenalex836 removed the SME stale The request for an SME has staled label Dec 26, 2024
@nguyenalex836
Copy link
Contributor

@jsoref Thank you for your patience while our SME team reviewed! They provided the following responses:

I don’t think this is valid, the customer is questioning that the actions exist without meeting the stated requirements but the stated requirements are only in regards to being published immediately without review by GitHub

I believe [the above] is correct, that bit is only stating about when actions are published immediately + automatically. You can have multiple actions in one repo but then you just have to follow the instructions further down the doc about publishing them.

Maybe the sentence could be reworked to be clearer, or a follow up added after the list of requirements that says something like: "If the action does not meet these requirements, follow the instructions below to publish it"

Let us know your thoughts regarding these review responses, and if you would be open to adding the suggested follow up statement after the list of requirements 💛

@nguyenalex836 nguyenalex836 added SME reviewed An SME has reviewed this issue/PR and removed waiting for review Issue/PR is waiting for a writer's review needs SME This proposal needs review from a subject matter expert labels Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team SME reviewed An SME has reviewed this issue/PR
Projects
None yet
Development

No branches or pull requests

2 participants