From d0f923f3b2748eac2fd51eab174f07eeb10c73da Mon Sep 17 00:00:00 2001 From: Charis Kyriakou Date: Mon, 6 Jan 2025 09:43:48 +0000 Subject: [PATCH 1/2] Remove support for CodeQL CLI versions older than v2.18.4 --- extensions/ql-vscode/src/codeql-cli/cli.ts | 2 +- extensions/ql-vscode/supported_cli_versions.json | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/extensions/ql-vscode/src/codeql-cli/cli.ts b/extensions/ql-vscode/src/codeql-cli/cli.ts index 7f090eff2ec..a34b6a351ea 100644 --- a/extensions/ql-vscode/src/codeql-cli/cli.ts +++ b/extensions/ql-vscode/src/codeql-cli/cli.ts @@ -1904,7 +1904,7 @@ function shouldDebugCliServer() { export class CliVersionConstraint { // The oldest version of the CLI that we support. This is used to determine // whether to show a warning about the CLI being too old on startup. - public static OLDEST_SUPPORTED_CLI_VERSION = new SemVer("2.16.6"); + public static OLDEST_SUPPORTED_CLI_VERSION = new SemVer("2.18.4"); constructor(private readonly cli: CodeQLCliServer) { /**/ diff --git a/extensions/ql-vscode/supported_cli_versions.json b/extensions/ql-vscode/supported_cli_versions.json index a0a72050ac9..97eddf8b5f3 100644 --- a/extensions/ql-vscode/supported_cli_versions.json +++ b/extensions/ql-vscode/supported_cli_versions.json @@ -3,7 +3,5 @@ "v2.19.4", "v2.19.3", "v2.18.4", - "v2.17.6", - "v2.16.6", "nightly" ] From d278085b3b6ff5c2d3d844857005644cd50ba5f2 Mon Sep 17 00:00:00 2001 From: Charis Kyriakou Date: Mon, 6 Jan 2025 10:54:35 +0000 Subject: [PATCH 2/2] Update CHANGELOG --- extensions/ql-vscode/CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/extensions/ql-vscode/CHANGELOG.md b/extensions/ql-vscode/CHANGELOG.md index bf5d9e316b9..78615a87792 100644 --- a/extensions/ql-vscode/CHANGELOG.md +++ b/extensions/ql-vscode/CHANGELOG.md @@ -2,6 +2,8 @@ ## [UNRELEASED] +- Remove support for CodeQL CLI versions older than 2.18.4. [#3895](https://github.com/github/vscode-codeql/pull/3895) + ## 1.7.0 - 20 December 2024 - Add a palette command that allows importing all databases directly inside of a parent folder. [#3797](https://github.com/github/vscode-codeql/pull/3797)