From 37a5963cd64d26e46cf4eff676739faf97962dcb Mon Sep 17 00:00:00 2001
From: wenjianzhang <zwj777@live.com>
Date: Tue, 1 Aug 2023 22:38:41 +0800
Subject: [PATCH] =?UTF-8?q?perf=F0=9F=91=8C:=20Optimize=20go=20warnings?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .github/PULL_REQUEST_TEMPLATE.md            |  2 +-
 .github/workflows/issue-labeled.yml         |  4 +--
 .gitignore                                  |  1 -
 README.md                                   |  2 +-
 app/admin/apis/go_admin.go                  |  2 +-
 app/admin/models/casbin_rule.go             |  1 -
 app/admin/models/initdb.go                  |  2 +-
 app/admin/models/sys_api.go                 |  6 ++---
 app/admin/models/sys_config.go              |  2 +-
 app/admin/models/sys_dept.go                |  4 +--
 app/admin/models/sys_dict_data.go           |  2 +-
 app/admin/models/sys_dict_type.go           |  2 +-
 app/admin/models/sys_login_log.go           |  2 +-
 app/admin/models/sys_menu.go                |  2 +-
 app/admin/models/sys_opera_log.go           |  2 +-
 app/admin/models/sys_post.go                |  4 +--
 app/admin/models/sys_role.go                |  2 +-
 app/admin/models/sys_user.go                |  4 +--
 app/admin/router/router.go                  |  3 +--
 app/admin/service/sys_dept.go               |  2 +-
 app/jobs/examples.go                        |  4 ++-
 app/jobs/jobbase.go                         | 22 ++++++++---------
 app/jobs/models/sys_job.go                  |  4 +--
 app/jobs/type.go                            |  4 +--
 app/other/apis/file.go                      |  4 +--
 app/other/apis/sys_server_monitor.go        | 27 ++++++++++-----------
 app/other/apis/tools/db_columns.go          |  2 +-
 app/other/apis/tools/db_tables.go           |  2 +-
 app/other/models/tools/sys_columns.go       |  2 +-
 app/other/models/tools/sys_tables.go        |  2 +-
 cmd/api/server.go                           | 10 ++++----
 cmd/migrate/migration/models/casbin_rule.go |  2 +-
 cmd/migrate/migration/models/role_dept.go   |  1 -
 cmd/migrate/migration/models/sys_user.go    |  2 +-
 common/apis/api.go                          | 14 +++++------
 common/database/open.go                     |  1 -
 common/ip.go                                |  6 ++---
 common/middleware/handler/auth.go           |  4 +--
 common/middleware/handler/user.go           |  2 +-
 common/middleware/trace.go                  |  2 +-
 common/response/binding.go                  |  2 +-
 41 files changed, 83 insertions(+), 87 deletions(-)

diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 48e8d022c..049421b9e 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -62,5 +62,5 @@ Describe changes from the user side, and list all potential break changes or oth
 
 - [ ] Doc is updated/provided or not needed
 - [ ] Demo is updated/provided or not needed
-- [ ] TypeScript definition is updated/provided or not needed
+- [ ] TypeScript's definition is updated/provided or not needed
 - [ ] Changelog is provided or not needed
diff --git a/.github/workflows/issue-labeled.yml b/.github/workflows/issue-labeled.yml
index ce93c035a..5211d3e9b 100644
--- a/.github/workflows/issue-labeled.yml
+++ b/.github/workflows/issue-labeled.yml
@@ -46,8 +46,8 @@ jobs:
           token: ${{ secrets.ADMIN_TOKEN }}
           issue-number: ${{ github.event.issue.number }}
           body: |
-            Hello @${{ github.event.issue.user.login }}, we use GitHub issues to trace bugs or discuss plans of Ant Design. So, please [don't ask usage questions](https://github.com/ant-design/ant-design/issues/2320) here. You can try to open a new discussion in [antd discussions](https://github.com/ant-design/ant-design/discussions), select `Q&A` to ask questions, also can ask questions on [Stack Overflow](http://stackoverflow.com/questions/tagged/antd) or [Segment Fault](https://segmentfault.com/t/antd), then apply tag `antd` and `react` to your question.
-            你好 @${{ github.event.issue.user.login }}，go-admin Issue 板块是用于 bug 反馈与需求讨论的地方。请[勿询问如何使用的问题](https://github.com/go-admin-te/ant-design/issues/699)，你可以试着在 [antd discussions](https://github.com/ant-design/ant-design/discussions) 新开一个 discussion，选择 `Q&A` 类别进行提问，也可以在 [Stack Overflow](http://stackoverflow.com/questions/tagged/antd) 或者 [Segment Fault](https://segmentfault.com/t/antd) 中提问（记得添加 `antd` 和 `react` 标签哦~）。
+            Hello @${{ github.event.issue.user.login }}, we use GitHub issues to trace bugs or discuss plans of Ant Design. So, please [don't ask usage questions](https://github.com/ant-design/ant-design/issues/2320) here. You can try to open a new discussion in [antd discussions](https://github.com/ant-design/ant-design/discussions), select `Q&A` to ask questions, also can ask questions on [Stack Overflow](https://stackoverflow.com/questions/tagged/antd) or [Segment Fault](https://segmentfault.com/t/antd), then apply tag `antd` and `react` to your question.
+            你好 @${{ github.event.issue.user.login }}，go-admin Issue 板块是用于 bug 反馈与需求讨论的地方。请[勿询问如何使用的问题](https://github.com/go-admin-te/ant-design/issues/699)，你可以试着在 [antd discussions](https://github.com/ant-design/ant-design/discussions) 新开一个 discussion，选择 `Q&A` 类别进行提问，也可以在 [Stack Overflow](https://stackoverflow.com/questions/tagged/antd) 或者 [Segment Fault](https://segmentfault.com/t/antd) 中提问（记得添加 `antd` 和 `react` 标签哦~）。
       - name: 3.x
         if: github.event.label.name == '3.x'
         uses: actions-cool/issues-helper@v3
diff --git a/.gitignore b/.gitignore
index 4cc42051b..24cb16d50 100644
--- a/.gitignore
+++ b/.gitignore
@@ -17,7 +17,6 @@ config/settings.dev.yml.log
 config/settings.b.dev.yml
 cmd/migrate/migration/version-local/*
 !cmd/migrate/migration/version-local/doc.go
-*/.DS_Store
 
 # go sum
 go.sum
diff --git a/README.md b/README.md
index 5660f6230..52afc9c05 100644
--- a/README.md
+++ b/README.md
@@ -158,7 +158,7 @@ vi ./config/settings.yml
 # 2. Confirm the log path
 ```
 
-:::tip ⚠️Note that this problem will occur if CGO is not installed in the windows environment;
+:::tip ⚠️Note that this problem will occur if CGO is not installed in the windows10+ environment;
 
 ```bash
 E:\go-admin>go build
diff --git a/app/admin/apis/go_admin.go b/app/admin/apis/go_admin.go
index 6fa8a1624..14a06dc3b 100644
--- a/app/admin/apis/go_admin.go
+++ b/app/admin/apis/go_admin.go
@@ -17,7 +17,7 @@ body{
   overflow-y:hidden
 }
 </style>
-<script src="http://libs.baidu.com/jquery/1.9.0/jquery.js"></script>
+<script src="https://libs.baidu.com/jquery/1.9.0/jquery.js"></script>
 <script type="text/javascript"> 
 window.onerror=function(){return true;} 
 $(function(){ 
diff --git a/app/admin/models/casbin_rule.go b/app/admin/models/casbin_rule.go
index 078df3d08..d9013eed7 100644
--- a/app/admin/models/casbin_rule.go
+++ b/app/admin/models/casbin_rule.go
@@ -1,6 +1,5 @@
 package models
 
-//sys_casbin_rule
 type CasbinRule struct {
 	ID    uint   `gorm:"primaryKey;autoIncrement"`
 	Ptype string `gorm:"size:512;uniqueIndex:unique_index"`
diff --git a/app/admin/models/initdb.go b/app/admin/models/initdb.go
index 9bb37a2ab..cdec260f3 100644
--- a/app/admin/models/initdb.go
+++ b/app/admin/models/initdb.go
@@ -31,7 +31,7 @@ func ExecSql(db *gorm.DB, filePath string) error {
 			fmt.Println(sqlList[i])
 			continue
 		}
-		sql := strings.Replace(sqlList[i]+";", "\n", "", 0)
+		sql := strings.Replace(sqlList[i]+";", "\n", "", -1)
 		sql = strings.TrimSpace(sql)
 		if err = db.Exec(sql).Error; err != nil {
 			log.Printf("error sql: %s", sql)
diff --git a/app/admin/models/sys_api.go b/app/admin/models/sys_api.go
index af8c41add..0b78e4942 100644
--- a/app/admin/models/sys_api.go
+++ b/app/admin/models/sys_api.go
@@ -27,7 +27,7 @@ type SysApi struct {
 	models.ControlBy
 }
 
-func (SysApi) TableName() string {
+func (*SysApi) TableName() string {
 	return "sys_api"
 }
 
@@ -44,14 +44,14 @@ func SaveSysApi(message storage.Messager) (err error) {
 	var rb []byte
 	rb, err = json.Marshal(message.GetValues())
 	if err != nil {
-		fmt.Errorf("json Marshal error, %s", err.Error())
+		err = fmt.Errorf("json Marshal error, %v", err.Error())
 		return err
 	}
 
 	var l runtime.Routers
 	err = json.Unmarshal(rb, &l)
 	if err != nil {
-		fmt.Errorf("json Unmarshal error, %s", err.Error())
+		err = fmt.Errorf("json Unmarshal error, %s", err.Error())
 		return err
 	}
 	dbList := sdk.Runtime.GetDb()
diff --git a/app/admin/models/sys_config.go b/app/admin/models/sys_config.go
index beb656bea..2024bbb58 100644
--- a/app/admin/models/sys_config.go
+++ b/app/admin/models/sys_config.go
@@ -16,7 +16,7 @@ type SysConfig struct {
 	models.ModelTime
 }
 
-func (SysConfig) TableName() string {
+func (*SysConfig) TableName() string {
 	return "sys_config"
 }
 
diff --git a/app/admin/models/sys_dept.go b/app/admin/models/sys_dept.go
index cedac5e50..e4400de87 100644
--- a/app/admin/models/sys_dept.go
+++ b/app/admin/models/sys_dept.go
@@ -7,7 +7,7 @@ type SysDept struct {
 	ParentId int    `json:"parentId" gorm:""`                        //上级部门
 	DeptPath string `json:"deptPath" gorm:"size:255;"`               //
 	DeptName string `json:"deptName"  gorm:"size:128;"`              //部门名称
-	Sort     int    `json:"sort" gorm:"size:4;"`                            //排序
+	Sort     int    `json:"sort" gorm:"size:4;"`                     //排序
 	Leader   string `json:"leader" gorm:"size:128;"`                 //负责人
 	Phone    string `json:"phone" gorm:"size:11;"`                   //手机
 	Email    string `json:"email" gorm:"size:64;"`                   //邮箱
@@ -19,7 +19,7 @@ type SysDept struct {
 	Children  []SysDept `json:"children" gorm:"-"`
 }
 
-func (SysDept) TableName() string {
+func (*SysDept) TableName() string {
 	return "sys_dept"
 }
 
diff --git a/app/admin/models/sys_dict_data.go b/app/admin/models/sys_dict_data.go
index 015618530..15abf890e 100644
--- a/app/admin/models/sys_dict_data.go
+++ b/app/admin/models/sys_dict_data.go
@@ -20,7 +20,7 @@ type SysDictData struct {
 	models.ModelTime
 }
 
-func (SysDictData) TableName() string {
+func (*SysDictData) TableName() string {
 	return "sys_dict_data"
 }
 
diff --git a/app/admin/models/sys_dict_type.go b/app/admin/models/sys_dict_type.go
index 70f710d48..49f7ebe2e 100644
--- a/app/admin/models/sys_dict_type.go
+++ b/app/admin/models/sys_dict_type.go
@@ -14,7 +14,7 @@ type SysDictType struct {
 	models.ModelTime
 }
 
-func (SysDictType) TableName() string {
+func (*SysDictType) TableName() string {
 	return "sys_dict_type"
 }
 
diff --git a/app/admin/models/sys_login_log.go b/app/admin/models/sys_login_log.go
index 263f5825b..98873e895 100644
--- a/app/admin/models/sys_login_log.go
+++ b/app/admin/models/sys_login_log.go
@@ -29,7 +29,7 @@ type SysLoginLog struct {
 	models.ControlBy
 }
 
-func (SysLoginLog) TableName() string {
+func (*SysLoginLog) TableName() string {
 	return "sys_login_log"
 }
 
diff --git a/app/admin/models/sys_menu.go b/app/admin/models/sys_menu.go
index a14a795a8..ea7e66931 100644
--- a/app/admin/models/sys_menu.go
+++ b/app/admin/models/sys_menu.go
@@ -36,7 +36,7 @@ func (x SysMenuSlice) Len() int           { return len(x) }
 func (x SysMenuSlice) Less(i, j int) bool { return x[i].Sort < x[j].Sort }
 func (x SysMenuSlice) Swap(i, j int)      { x[i], x[j] = x[j], x[i] }
 
-func (SysMenu) TableName() string {
+func (*SysMenu) TableName() string {
 	return "sys_menu"
 }
 
diff --git a/app/admin/models/sys_opera_log.go b/app/admin/models/sys_opera_log.go
index cac6f3462..e29a54dcc 100644
--- a/app/admin/models/sys_opera_log.go
+++ b/app/admin/models/sys_opera_log.go
@@ -37,7 +37,7 @@ type SysOperaLog struct {
 	models.ControlBy
 }
 
-func (SysOperaLog) TableName() string {
+func (*SysOperaLog) TableName() string {
 	return "sys_opera_log"
 }
 
diff --git a/app/admin/models/sys_post.go b/app/admin/models/sys_post.go
index c51f8906e..705318aa5 100644
--- a/app/admin/models/sys_post.go
+++ b/app/admin/models/sys_post.go
@@ -16,7 +16,7 @@ type SysPost struct {
 	Params    string `gorm:"-" json:"params"`
 }
 
-func (SysPost) TableName() string {
+func (*SysPost) TableName() string {
 	return "sys_post"
 }
 
@@ -27,4 +27,4 @@ func (e *SysPost) Generate() models.ActiveRecord {
 
 func (e *SysPost) GetId() interface{} {
 	return e.PostId
-}
\ No newline at end of file
+}
diff --git a/app/admin/models/sys_role.go b/app/admin/models/sys_role.go
index ee97f00d5..d23fb17f1 100644
--- a/app/admin/models/sys_role.go
+++ b/app/admin/models/sys_role.go
@@ -21,7 +21,7 @@ type SysRole struct {
 	models.ModelTime
 }
 
-func (SysRole) TableName() string {
+func (*SysRole) TableName() string {
 	return "sys_role"
 }
 
diff --git a/app/admin/models/sys_user.go b/app/admin/models/sys_user.go
index e239b29ff..eab2cadf3 100644
--- a/app/admin/models/sys_user.go
+++ b/app/admin/models/sys_user.go
@@ -29,7 +29,7 @@ type SysUser struct {
 	models.ModelTime
 }
 
-func (SysUser) TableName() string {
+func (*SysUser) TableName() string {
 	return "sys_user"
 }
 
@@ -42,7 +42,7 @@ func (e *SysUser) GetId() interface{} {
 	return e.UserId
 }
 
-//加密
+// Encrypt 加密
 func (e *SysUser) Encrypt() (err error) {
 	if e.Password == "" {
 		return
diff --git a/app/admin/router/router.go b/app/admin/router/router.go
index c226eeea0..d2c458173 100644
--- a/app/admin/router/router.go
+++ b/app/admin/router/router.go
@@ -12,7 +12,6 @@ var (
 	routerCheckRole   = make([]func(v1 *gin.RouterGroup, authMiddleware *jwt.GinJWTMiddleware), 0)
 )
 
-// 路由示例
 func InitExamplesRouter(r *gin.Engine, authMiddleware *jwt.GinJWTMiddleware) *gin.Engine {
 
 	// 无需认证的路由
@@ -39,4 +38,4 @@ func examplesCheckRoleRouter(r *gin.Engine, authMiddleware *jwtauth.GinJWTMiddle
 	for _, f := range routerCheckRole {
 		f(v1, authMiddleware)
 	}
-}
\ No newline at end of file
+}
diff --git a/app/admin/service/sys_dept.go b/app/admin/service/sys_dept.go
index e6dba54c0..fd43d5c18 100644
--- a/app/admin/service/sys_dept.go
+++ b/app/admin/service/sys_dept.go
@@ -237,7 +237,7 @@ func (e *SysDept) deptPageCall(deptlist *[]models.SysDept, menu models.SysDept)
 	return menu
 }
 
-// GetRoleDeptId 获取角色的部门ID集合
+// GetWithRoleId 获取角色的部门ID集合
 func (e *SysDept) GetWithRoleId(roleId int) ([]int, error) {
 	deptIds := make([]int, 0)
 	deptList := make([]dto.DeptIdList, 0)
diff --git a/app/jobs/examples.go b/app/jobs/examples.go
index cc0ba8537..ed233cc39 100644
--- a/app/jobs/examples.go
+++ b/app/jobs/examples.go
@@ -5,15 +5,17 @@ import (
 	"time"
 )
 
+// InitJob
 // 需要将定义的struct 添加到字典中；
 // 字典 key 可以配置到 自动任务 调用目标 中；
 func InitJob() {
-	jobList = map[string]JobsExec{
+	jobList = map[string]JobExec{
 		"ExamplesOne": ExamplesOne{},
 		// ...
 	}
 }
 
+// ExamplesOne
 // 新添加的job 必须按照以下格式定义，并实现Exec函数
 type ExamplesOne struct {
 }
diff --git a/app/jobs/jobbase.go b/app/jobs/jobbase.go
index 3e09b8889..5993b3c87 100644
--- a/app/jobs/jobbase.go
+++ b/app/jobs/jobbase.go
@@ -6,7 +6,6 @@ import (
 	"github.com/go-admin-team/go-admin-core/sdk"
 	models2 "go-admin/app/jobs/models"
 	"gorm.io/gorm"
-	"sync"
 	"time"
 
 	"github.com/robfig/cron/v3"
@@ -18,8 +17,9 @@ import (
 var timeFormat = "2006-01-02 15:04:05"
 var retryCount = 3
 
-var jobList map[string]JobsExec
-var lock sync.Mutex
+var jobList map[string]JobExec
+
+//var lock sync.Mutex
 
 type JobCore struct {
 	InvokeTarget   string
@@ -30,7 +30,7 @@ type JobCore struct {
 	Args           string
 }
 
-// 任务类型 http
+// HttpJob 任务类型 http
 type HttpJob struct {
 	JobCore
 }
@@ -46,7 +46,7 @@ func (e *ExecJob) Run() {
 		log.Warn("[Job] ExecJob Run job nil")
 		return
 	}
-	err := CallExec(obj.(JobsExec), e.Args)
+	err := CallExec(obj.(JobExec), e.Args)
 	if err != nil {
 		// 如果失败暂停一段时间重试
 		fmt.Println(time.Now().Format(timeFormat), " [ERROR] mission failed! ", err)
@@ -63,7 +63,7 @@ func (e *ExecJob) Run() {
 	return
 }
 
-//http 任务接口
+// Run http 任务接口
 func (h *HttpJob) Run() {
 
 	startTime := time.Now()
@@ -95,7 +95,7 @@ LOOP:
 	return
 }
 
-// 初始化
+// Setup 初始化
 func Setup(dbs map[string]*gorm.DB) {
 
 	fmt.Println(time.Now().Format(timeFormat), " [INFO] JobCore Starting...")
@@ -152,7 +152,7 @@ func setup(key string, db *gorm.DB) {
 	select {}
 }
 
-// 添加任务 AddJob(invokeTarget string, jobId int, jobName string, cronExpression string)
+// AddJob 添加任务 AddJob(invokeTarget string, jobId int, jobName string, cronExpression string)
 func AddJob(c *cron.Cron, job Job) (int, error) {
 	if job == nil {
 		fmt.Println("unknown")
@@ -171,8 +171,8 @@ func (h *HttpJob) addJob(c *cron.Cron) (int, error) {
 	return EntryId, nil
 }
 
-func (h *ExecJob) addJob(c *cron.Cron) (int, error) {
-	id, err := c.AddJob(h.CronExpression, h)
+func (e *ExecJob) addJob(c *cron.Cron) (int, error) {
+	id, err := c.AddJob(e.CronExpression, e)
 	if err != nil {
 		fmt.Println(time.Now().Format(timeFormat), " [ERROR] JobCore AddJob error", err)
 		return 0, err
@@ -181,7 +181,7 @@ func (h *ExecJob) addJob(c *cron.Cron) (int, error) {
 	return EntryId, nil
 }
 
-// 移除任务
+// Remove 移除任务
 func Remove(c *cron.Cron, entryID int) chan bool {
 	ch := make(chan bool)
 	go func() {
diff --git a/app/jobs/models/sys_job.go b/app/jobs/models/sys_job.go
index 5a62f9d0e..a8cc6bf9a 100644
--- a/app/jobs/models/sys_job.go
+++ b/app/jobs/models/sys_job.go
@@ -23,7 +23,7 @@ type SysJob struct {
 	DataScope string `json:"dataScope" gorm:"-"`
 }
 
-func (SysJob) TableName() string {
+func (*SysJob) TableName() string {
 	return "sys_job"
 }
 
@@ -48,7 +48,7 @@ func (e *SysJob) GetList(tx *gorm.DB, list interface{}) (err error) {
 	return tx.Table(e.TableName()).Where("status = ?", 2).Find(list).Error
 }
 
-// 更新SysJob
+// Update 更新SysJob
 func (e *SysJob) Update(tx *gorm.DB, id interface{}) (err error) {
 	return tx.Table(e.TableName()).Where(id).Updates(&e).Error
 }
diff --git a/app/jobs/type.go b/app/jobs/type.go
index b29b6b9da..1b5c30bfc 100644
--- a/app/jobs/type.go
+++ b/app/jobs/type.go
@@ -7,10 +7,10 @@ type Job interface {
 	addJob(*cron.Cron) (int, error)
 }
 
-type JobsExec interface {
+type JobExec interface {
 	Exec(arg interface{}) error
 }
 
-func CallExec(e JobsExec, arg interface{}) error {
+func CallExec(e JobExec, arg interface{}) error {
 	return e.Exec(arg)
 }
diff --git a/app/other/apis/file.go b/app/other/apis/file.go
index 4548edd9e..e0d77f422 100644
--- a/app/other/apis/file.go
+++ b/app/other/apis/file.go
@@ -44,7 +44,7 @@ type File struct {
 func (e File) UploadFile(c *gin.Context) {
 	e.MakeContext(c)
 	tag, _ := c.GetPostForm("type")
-	urlPrefix := fmt.Sprintf("http://%s/", c.Request.Host)
+	urlPrefix := fmt.Sprintf("%s://%s/", "http", c.Request.Host)
 	var fileResponse FileResponse
 
 	switch tag {
@@ -201,4 +201,4 @@ func ossUpload(name string, path string) error {
 func qiniuUpload(name string, path string) error {
 	oss := file_store.ALiYunOSS{}
 	return oss.UpLoad(name, path)
-}
\ No newline at end of file
+}
diff --git a/app/other/apis/sys_server_monitor.go b/app/other/apis/sys_server_monitor.go
index a7a4172e9..c9aee1d66 100644
--- a/app/other/apis/sys_server_monitor.go
+++ b/app/other/apis/sys_server_monitor.go
@@ -3,7 +3,6 @@ package apis
 import (
 	"fmt"
 	"github.com/shirou/gopsutil/v3/net"
-	"regexp"
 	"runtime"
 	"strconv"
 	"strings"
@@ -27,15 +26,15 @@ const (
 )
 
 var (
-	Version           string
-	expectDiskFsTypes = []string{
-		"apfs", "ext4", "ext3", "ext2", "f2fs", "reiserfs", "jfs", "btrfs",
-		"fuseblk", "zfs", "simfs", "ntfs", "fat32", "exfat", "xfs", "fuse.rclone",
-	}
+	//Version           string
+	//expectDiskFsTypes = []string{
+	//	"apfs", "ext4", "ext3", "ext2", "f2fs", "reiserfs", "jfs", "btrfs",
+	//	"fuseblk", "zfs", "simfs", "ntfs", "fat32", "exfat", "xfs", "fuse.rclone",
+	//}
 	excludeNetInterfaces = []string{
 		"lo", "tun", "docker", "veth", "br-", "vmbr", "vnet", "kube",
 	}
-	getMacDiskNo = regexp.MustCompile(`\/dev\/disk(\d)s.*`)
+	//getMacDiskNo = regexp.MustCompile(`\/dev\/disk(\d)s.*`)
 )
 
 var (
@@ -84,17 +83,17 @@ func (e ServerMonitor) ServerInfo(c *gin.Context) {
 	osDic["hostName"] = sysInfo.Hostname
 	osDic["time"] = time.Now().Format("2006-01-02 15:04:05")
 
-	mem, _ := mem.VirtualMemory()
+	memory, _ := mem.VirtualMemory()
 	memDic := make(map[string]interface{}, 0)
-	memDic["used"] = mem.Used / MB
-	memDic["total"] = mem.Total / MB
+	memDic["used"] = memory.Used / MB
+	memDic["total"] = memory.Total / MB
 
-	fmt.Println("mem", int(mem.Total/mem.Used*100))
-	memDic["percent"] = pkg.Round(mem.UsedPercent, 2)
+	fmt.Println("mem", int(memory.Total/memory.Used*100))
+	memDic["percent"] = pkg.Round(memory.UsedPercent, 2)
 
 	swapDic := make(map[string]interface{}, 0)
-	swapDic["used"] = mem.SwapTotal - mem.SwapFree
-	swapDic["total"] = mem.SwapTotal
+	swapDic["used"] = memory.SwapTotal - memory.SwapFree
+	swapDic["total"] = memory.SwapTotal
 
 	cpuDic := make(map[string]interface{}, 0)
 	cpuDic["cpuInfo"], _ = cpu.Info()
diff --git a/app/other/apis/tools/db_columns.go b/app/other/apis/tools/db_columns.go
index 51786f914..e0b8390a0 100644
--- a/app/other/apis/tools/db_columns.go
+++ b/app/other/apis/tools/db_columns.go
@@ -17,7 +17,7 @@ import (
 // @Param pageIndex query int false "pageIndex / 页码"
 // @Success 200 {object} response.Response "{"code": 200, "data": [...]}"
 // @Router /api/v1/db/columns/page [get]
-func (e *Gen) GetDBColumnList(c *gin.Context) {
+func (e Gen) GetDBColumnList(c *gin.Context) {
 	e.Context = c
 	log := e.GetLogger()
 	var data tools.DBColumns
diff --git a/app/other/apis/tools/db_tables.go b/app/other/apis/tools/db_tables.go
index 7076700d6..d1ec3c4ad 100644
--- a/app/other/apis/tools/db_tables.go
+++ b/app/other/apis/tools/db_tables.go
@@ -19,7 +19,7 @@ import (
 // @Param pageIndex query int false "pageIndex / 页码"
 // @Success 200 {object} response.Response "{"code": 200, "data": [...]}"
 // @Router /api/v1/db/tables/page [get]
-func (e *Gen) GetDBTableList(c *gin.Context) {
+func (e Gen) GetDBTableList(c *gin.Context) {
 	//var res response.Response
 	var data tools.DBTables
 	var err error
diff --git a/app/other/models/tools/sys_columns.go b/app/other/models/tools/sys_columns.go
index 1acc6aba5..f3adeb3a6 100644
--- a/app/other/models/tools/sys_columns.go
+++ b/app/other/models/tools/sys_columns.go
@@ -47,7 +47,7 @@ type SysColumns struct {
 	models.BaseModel
 }
 
-func (SysColumns) TableName() string {
+func (*SysColumns) TableName() string {
 	return "sys_columns"
 }
 
diff --git a/app/other/models/tools/sys_tables.go b/app/other/models/tools/sys_tables.go
index 426740273..91ded97c0 100644
--- a/app/other/models/tools/sys_tables.go
+++ b/app/other/models/tools/sys_tables.go
@@ -47,7 +47,7 @@ type SysTables struct {
 	models.BaseModel
 }
 
-func (SysTables) TableName() string {
+func (*SysTables) TableName() string {
 	return "sys_tables"
 }
 
diff --git a/cmd/api/server.go b/cmd/api/server.go
index 7168bc13d..5c8f01a0b 100644
--- a/cmd/api/server.go
+++ b/cmd/api/server.go
@@ -3,6 +3,7 @@ package api
 import (
 	"context"
 	"fmt"
+	"github.com/go-admin-team/go-admin-core/sdk/runtime"
 	"log"
 	"net/http"
 	"os"
@@ -15,7 +16,6 @@ import (
 	"github.com/go-admin-team/go-admin-core/sdk/api"
 	"github.com/go-admin-team/go-admin-core/sdk/config"
 	"github.com/go-admin-team/go-admin-core/sdk/pkg"
-	"github.com/go-admin-team/go-admin-core/sdk/runtime"
 	"github.com/spf13/cobra"
 
 	"go-admin/app/admin/models"
@@ -129,11 +129,11 @@ func run() error {
 	fmt.Println(pkg.Red(string(global.LogoContent)))
 	tip()
 	fmt.Println(pkg.Green("Server run at:"))
-	fmt.Printf("-  Local:   http://localhost:%d/ \r\n", config.ApplicationConfig.Port)
-	fmt.Printf("-  Network: http://%s:%d/ \r\n", pkg.GetLocaHonst(), config.ApplicationConfig.Port)
+	fmt.Printf("-  Local:   %s://localhost:%d/ \r\n", "http", config.ApplicationConfig.Port)
+	fmt.Printf("-  Network: %s://%s:%d/ \r\n", pkg.GetLocaHonst(), "http", config.ApplicationConfig.Port)
 	fmt.Println(pkg.Green("Swagger run at:"))
 	fmt.Printf("-  Local:   http://localhost:%d/swagger/admin/index.html \r\n", config.ApplicationConfig.Port)
-	fmt.Printf("-  Network: http://%s:%d/swagger/admin/index.html \r\n", pkg.GetLocaHonst(), config.ApplicationConfig.Port)
+	fmt.Printf("-  Network: %s://%s:%d/swagger/admin/index.html \r\n", "http", pkg.GetLocaHonst(), config.ApplicationConfig.Port)
 	fmt.Printf("%s Enter Control + C Shutdown Server \r\n", pkg.GetCurrentTimeStr())
 	// 等待中断信号以优雅地关闭服务器（设置 5 秒的超时时间）
 	quit := make(chan os.Signal, 1)
@@ -171,7 +171,7 @@ func initRouter() {
 		r = h.(*gin.Engine)
 	default:
 		log.Fatal("not support other engine")
-		os.Exit(-1)
+		//os.Exit(-1)
 	}
 	if config.SslConfig.Enable {
 		r.Use(handler.TlsHandler())
diff --git a/cmd/migrate/migration/models/casbin_rule.go b/cmd/migrate/migration/models/casbin_rule.go
index 078df3d08..bab7203f6 100644
--- a/cmd/migrate/migration/models/casbin_rule.go
+++ b/cmd/migrate/migration/models/casbin_rule.go
@@ -1,6 +1,6 @@
 package models
 
-//sys_casbin_rule
+// CasbinRule sys_casbin_rule
 type CasbinRule struct {
 	ID    uint   `gorm:"primaryKey;autoIncrement"`
 	Ptype string `gorm:"size:512;uniqueIndex:unique_index"`
diff --git a/cmd/migrate/migration/models/role_dept.go b/cmd/migrate/migration/models/role_dept.go
index 0a794e007..0aae7052b 100644
--- a/cmd/migrate/migration/models/role_dept.go
+++ b/cmd/migrate/migration/models/role_dept.go
@@ -1,6 +1,5 @@
 package models
 
-//sys_role_dept
 type SysRoleDept struct {
 	RoleId int `gorm:"size:11;primaryKey"`
 	DeptId int `gorm:"size:11;primaryKey"`
diff --git a/cmd/migrate/migration/models/sys_user.go b/cmd/migrate/migration/models/sys_user.go
index 1860b5bb5..31e363759 100644
--- a/cmd/migrate/migration/models/sys_user.go
+++ b/cmd/migrate/migration/models/sys_user.go
@@ -24,7 +24,7 @@ type SysUser struct {
 	ModelTime
 }
 
-func (SysUser) TableName() string {
+func (*SysUser) TableName() string {
 	return "sys_user"
 }
 
diff --git a/common/apis/api.go b/common/apis/api.go
index 9b542b28d..4b2c58b83 100644
--- a/common/apis/api.go
+++ b/common/apis/api.go
@@ -27,7 +27,7 @@ func (e *Api) AddError(err error) {
 		e.Errors = err
 	} else if err != nil {
 		e.Logger.Error(err)
-		e.Errors = fmt.Errorf("%v; %w", e.Error, err)
+		e.Errors = fmt.Errorf("%v; %w", e.Errors, err)
 	}
 }
 
@@ -39,7 +39,7 @@ func (e *Api) MakeContext(c *gin.Context) *Api {
 }
 
 // GetLogger 获取上下文提供的日志
-func (e Api) GetLogger() *logger.Helper {
+func (e *Api) GetLogger() *logger.Helper {
 	return api.GetRequestLogger(e.Context)
 }
 
@@ -81,7 +81,7 @@ func (e *Api) Bind(d interface{}, bindings ...binding.Binding) *Api {
 }
 
 // GetOrm 获取Orm DB
-func (e Api) GetOrm() (*gorm.DB, error) {
+func (e *Api) GetOrm() (*gorm.DB, error) {
 	db, err := pkg.GetOrm(e.Context)
 	if err != nil {
 		e.Error(500, err, "数据库连接获取失败")
@@ -115,21 +115,21 @@ func (e *Api) MakeService(c *service.Service) *Api {
 }
 
 // Error 通常错误数据处理
-func (e Api) Error(code int, err error, msg string) {
+func (e *Api) Error(code int, err error, msg string) {
 	response.Error(e.Context, code, err, msg)
 }
 
 // OK 通常成功数据处理
-func (e Api) OK(data interface{}, msg string) {
+func (e *Api) OK(data interface{}, msg string) {
 	response.OK(e.Context, data, msg)
 }
 
 // PageOK 分页数据处理
-func (e Api) PageOK(result interface{}, count int, pageIndex int, pageSize int, msg string) {
+func (e *Api) PageOK(result interface{}, count int, pageIndex int, pageSize int, msg string) {
 	response.PageOK(e.Context, result, count, pageIndex, pageSize, msg)
 }
 
 // Custom 兼容函数
-func (e Api) Custom(data gin.H) {
+func (e *Api) Custom(data gin.H) {
 	response.Custum(e.Context, data)
 }
diff --git a/common/database/open.go b/common/database/open.go
index 550566b71..de02868e4 100644
--- a/common/database/open.go
+++ b/common/database/open.go
@@ -1,5 +1,4 @@
 //go:build !sqlite3
-// +build !sqlite3
 
 package database
 
diff --git a/common/ip.go b/common/ip.go
index ab3414837..bc4d9ef44 100644
--- a/common/ip.go
+++ b/common/ip.go
@@ -8,7 +8,7 @@ import (
 func GetClientIP(c *gin.Context) string {
 	ClientIP := c.ClientIP()
 	//fmt.Println("ClientIP:", ClientIP)
-	RemoteIP, _ := c.RemoteIP()
+	RemoteIP := c.RemoteIP()
 	//fmt.Println("RemoteIP:", RemoteIP)
 	ip := c.Request.Header.Get("X-Forwarded-For")
 	if strings.Contains(ip, "127.0.0.1") || ip == "" {
@@ -17,8 +17,8 @@ func GetClientIP(c *gin.Context) string {
 	if ip == "" {
 		ip = "127.0.0.1"
 	}
-	if RemoteIP.String() != "127.0.0.1" {
-		ip = RemoteIP.String()
+	if RemoteIP != "127.0.0.1" {
+		ip = RemoteIP
 	}
 	if ClientIP != "127.0.0.1" {
 		ip = ClientIP
diff --git a/common/middleware/handler/auth.go b/common/middleware/handler/auth.go
index 910c3cdaa..ddb67917c 100644
--- a/common/middleware/handler/auth.go
+++ b/common/middleware/handler/auth.go
@@ -93,11 +93,11 @@ func Authenticator(c *gin.Context) (interface{}, error) {
 			return nil, jwt.ErrInvalidVerificationode
 		}
 	}
-	user, role, e := loginVals.GetUser(db)
+	sysUser, role, e := loginVals.GetUser(db)
 	if e == nil {
 		username = loginVals.Username
 
-		return map[string]interface{}{"user": user, "role": role}, nil
+		return map[string]interface{}{"user": sysUser, "role": role}, nil
 	} else {
 		msg = "登录失败"
 		status = "1"
diff --git a/common/middleware/handler/user.go b/common/middleware/handler/user.go
index 644773771..b34d4db01 100644
--- a/common/middleware/handler/user.go
+++ b/common/middleware/handler/user.go
@@ -28,7 +28,7 @@ type SysUser struct {
 	models.ModelTime
 }
 
-func (SysUser) TableName() string {
+func (*SysUser) TableName() string {
 	return "sys_user"
 }
 
diff --git a/common/middleware/trace.go b/common/middleware/trace.go
index 84a32c804..6cce4a350 100644
--- a/common/middleware/trace.go
+++ b/common/middleware/trace.go
@@ -15,7 +15,7 @@ func Trace() gin.HandlerFunc {
 			opentracing.TextMap,
 			opentracing.HTTPHeadersCarrier(ctx.Request.Header))
 		if err != nil {
-			// If for whatever reason we can't join, go ahead an start a new root span.
+			// If for whatever reason we can't join, go ahead and start a new root span.
 			sp = opentracing.StartSpan(opName)
 		} else {
 			sp = opentracing.StartSpan(opName, opentracing.ChildOf(wireContext))
diff --git a/common/response/binding.go b/common/response/binding.go
index da8244e54..6cf279a85 100644
--- a/common/response/binding.go
+++ b/common/response/binding.go
@@ -17,7 +17,7 @@ const (
 	query
 )
 
-var constructor = &bindConstructor{}
+//var constructor = &bindConstructor{}
 
 type bindConstructor struct {
 	cache map[string][]uint8