Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rebuild wheels for newly released Brotli v1.1.0 #18

Closed
anthrotype opened this issue Sep 4, 2023 · 4 comments · Fixed by #20
Closed

rebuild wheels for newly released Brotli v1.1.0 #18

anthrotype opened this issue Sep 4, 2023 · 4 comments · Fixed by #20
Assignees
@anthrotype

Comments

@anthrotype
Copy link
Member

https://github.com/google/brotli/releases/tag/v1.1.0
@anthrotype anthrotype self-assigned this Sep 4, 2023
@anthrotype anthrotype mentioned this issue Sep 5, 2023
Open
anthrotype added a commit that referenced this issue Sep 5, 2023
@anthrotype
Build wheels for Python 3.12; disable PyPy wheels
f098a83 
Fixes #18. For PyPy see #19
This was referenced Sep 5, 2023
Merged
Open
@anthrotype
Copy link
Member Author

If everything goes according to plan, in a couple of hours all 83 (!) brotli wheels will be built and uploaded automatically to PyPI. You can follow along here: https://github.com/google/brotli-wheels/actions/runs/6086252565

@anthrotype anthrotype reopened this Sep 5, 2023
@anthrotype
Copy link
Member Author

anthrotype commented Sep 5, 2023 •
edited
Loading

oh no.. automatic upload to PyPI failed with a surprising error.. :(

ERROR    `long_description` has syntax errors in markup and would not be        
         rendered on PyPI.                                                      
         No content rendered from RST source.

https://github.com/google/brotli-wheels/actions/runs/6086252565/job/16514371203

I'll take a look tomorrow

@anthrotype
Copy link
Member Author

ugh.. looks like twine now fails if long_description setup.py parameter is not set like in Brotli

pypa/twine#960

I think for v1.1.0 I will just pin twine to an earlier version that doesn't complain, then we can add a long_description in brotli's setup.py if we wish to do so at a later stage (any changes there won't be seen until a new release)

@anthrotype anthrotype mentioned this issue Sep 6, 2023
Merged
anthrotype added a commit to anthrotype/brotli that referenced this issue Sep 6, 2023
@anthrotype
setup.py: add long_description
4541387 
twine (the tool we use to upload packages to PyPI) is currently failing if the long_description (used to render a project's page on PyPI website) is not set. Somehow it complains that it is not well formatted reStructuredText, but it's simply empty...
This looks like a bug, or bad interaction between twince and setuptools, because the field is technically optional.
Also see pypa/twine#960 and pypa/twine#908.

This issue is currently preventing the upload of newly built Brotli v1.1.0 Python wheels to PyPI:
google/brotli-wheels#18 (comment)

Anyway, we may well set the long_description to the content of the README.md file, as it's customary for python projects.
eustas pushed a commit to google/brotli that referenced this issue Sep 7, 2023
@anthrotype
setup.py: add long_description (#1073)
2ce8566 
twine (the tool we use to upload packages to PyPI) is currently failing if the long_description (used to render a project's page on PyPI website) is not set. Somehow it complains that it is not well formatted reStructuredText, but it's simply empty...
This looks like a bug, or bad interaction between twince and setuptools, because the field is technically optional.
Also see pypa/twine#960 and pypa/twine#908.

This issue is currently preventing the upload of newly built Brotli v1.1.0 Python wheels to PyPI:
google/brotli-wheels#18 (comment)

Anyway, we may well set the long_description to the content of the README.md file, as it's customary for python projects.
@anthrotype
Copy link
Member Author

wheels for v1.1.0 release are up and running: https://pypi.org/project/Brotli/1.1.0/#files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anthrotype anthrotype

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Build wheels for Python 3.12; disable PyPy wheels google/brotli-wheels
1 participant
@anthrotype