Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inform about bad keys #376

Open
jpoehnelt opened this issue Sep 14, 2021 · 4 comments
Open

Inform about bad keys #376

jpoehnelt opened this issue Sep 14, 2021 · 4 comments
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@jpoehnelt
Copy link
Contributor

Not sure what the implementation should look like. But it would be useful to know if they key is valid or not and allow a different code path in the application.

@jpoehnelt jpoehnelt added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. triage me I really want to be triaged. labels Sep 14, 2021
@eegli
Copy link

eegli commented Sep 21, 2021

Same issue here.

As per the docs:

// Promise
loader
  .load()
  .then((google) => {
    new google.maps.Map(document.getElementById("map"), mapOptions);
  })
  .catch(e => {
    // do something
  });

I'd usually expect that errors from "bad keys" can be caught here. I need such validation logic as I'm letting my users input their own keys for testing purposes.

Is there even a way to validate maps api keys? I have not found anything in the docs.

@jpoehnelt
Copy link
Contributor Author

@eegli see #395

@sgurin
Copy link

sgurin commented Apr 7, 2023

Is any news? @wangela

@usefulthink usefulthink removed the triage me I really want to be triaged. label Sep 13, 2023
@usefulthink
Copy link
Contributor

This can be implemented in client-code using the window.gm_authFailure callback.

Since the key-validation happens at an unknown time while using the API, it is not possible to include this information in the response to the load() or importLibrary calls. In a future version, we will consider making possible errors available via events or other loader-properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants