Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout Scene: Reorganize variables #971

Open
gtk-grafana opened this issue Dec 20, 2024 · 0 comments
Open

Layout Scene: Reorganize variables #971

gtk-grafana opened this issue Dec 20, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@gtk-grafana
Copy link
Contributor

gtk-grafana commented Dec 20, 2024

With line filters being moved into the variables in the header, we've got quite a lot going on when queries get more complex:

Image

While at least the variables are in the same order as the logQL query now, I think we should do a better job illustrating that the order of operations is a function of how loki will find the logs you are searching for.

Also things look "messy", and we could do a better job collapsing and expanding variables so the header doesn't take up so much vertical space.

Some things we discussed:

  • Move labels "combobox" on it's own line
  • Move the feedback link to the left of the time picker
  • put datasource and datapicker/refresh on the same line.
  • Adding borders and indentiation to better separate each variable type
  • Unifying styles, we've got "pill" style for the combobox and patterns, but "input" style on the fields and the line filters.
  • Collapsing patterns

Some things we haven't discussed:

  • Drag and drop all variables to change the filter order (within each row, users shouldn't be able to put a line filter or field variable before a metadata variable)

CC @zizzpudding

@gtk-grafana gtk-grafana added the enhancement New feature or request label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants