Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: do we need to expose the pixel size? #980

Open
matyax opened this issue Jan 6, 2025 · 4 comments
Open

Table: do we need to expose the pixel size? #980

matyax opened this issue Jan 6, 2025 · 4 comments

Comments

@matyax
Copy link
Contributor

matyax commented Jan 6, 2025

We are currently exposing the pixel size of the columns to the user, which seems like very specific and unnecessary information.

In addition: should the widths auto update size when adding/removing columns?

@matyax
Copy link
Contributor Author

matyax commented Jan 6, 2025

FYI @gtk-grafana . You probably thought about this one and there may be a challenge on the fix, but it's a bit deterrent of using the table viz (at least for me).

In addition, do you think it's worth to expose the pixel size to the user?

Image

Clearing the width seems ok, but the exact amount of pixels seems like unnecessary information.

@gtk-grafana
Copy link
Contributor

Yeah the line field should use all of the available space (minus the width of the other columns), unless one has been defined manually by resizing the column via drag-n-drop, then you'll see this.

It might be better to add an additional icon to the columnheader to let folks clear out the defined width instead of tucking that away.

And agreed, exposing the pixel size is probably not needed, and confusing.

@matyax
Copy link
Contributor Author

matyax commented Jan 8, 2025

Ahhhh! I probably set it at some point without realizing. Cool. Maybe just skip the pixel size, then.

@matyax matyax changed the title Table: improve column size for body column Table: do we need to expose the pixel size? Jan 8, 2025
@gtk-grafana
Copy link
Contributor

I think you made a good point though, if you accidentally resize something you have to dig around in the UI to fix it, should be something that displays top-level to let users clear the custom column size. If you ran into this I'm sure it's frustrating some users as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants